From kde-panel-devel Wed Mar 26 12:12:02 2014 From: "Kai Uwe Broulik" Date: Wed, 26 Mar 2014 12:12:02 +0000 To: kde-panel-devel Subject: Re: Review Request 115409: Workaround battery detection at runtime Message-Id: <20140326121202.27691.17208 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139583594713635 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6784467055082856658==" --===============6784467055082856658== Content-Type: multipart/alternative; boundary="===============7339206155156458779==" --===============7339206155156458779== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On March 7, 2014, 12:19 p.m., Christoph Feck wrote: > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 > > > > > > Removal of this causes two other regressions: bug 331797, bug 331831. > > > > I re-added the "onDataChanged:" handling and both bugs are gone, but I only have a single battery, so I cannot test if bug 324847 is still fixed. > > Kai Uwe Broulik wrote: > Sorry for the inconvenience :-( > > Will try to test your patch [1] tomorrow. > > [1] http://bugsfiles.kde.org/attachment.cgi?id=85464 > > > Christoph Feck wrote: > Don't worry :) The regressions are minor, and to be honest, I would prefer to not commit my patch, unless we find a way to get both bug 321823 and the regressions fixed. > > Kai Uwe Broulik wrote: > Just tested it, plugged in and out my mouse multiple times and it appears and re-appears, and also the tooltip (which is reported broken in Bug 324847 Comment 19) seems properly updated. > > Go ahead and push it, thanks for taking care of this! :-) > > Christoph Feck wrote: > But then we would get bug 321823 again... I think showing wrong brightness (0%) is worse than the auto-closing popup with Ac plugged in and battery charged and the thing hidden in the popup. I'm seeing a lot of posts about this regression on G+ and other sources lately. So, please push. :/ Plasma Next should fix the Bug 321823 for us at least I guess. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review52338 ----------------------------------------------------------- On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115409/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 10:19 p.m.) > > > Review request for Plasma, Solid and Sebastian Kügler. > > > Bugs: 324847 > http://bugs.kde.org/show_bug.cgi?id=324847 > > > Repository: kde-workspace > > > Description > ------- > > For some reason when a new battery appears (eg. mouse plugged in), the battery does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer, however. > I am really clueless on to what causes this, so I just throw this patch in for enlightenment as it sort of makes it work. :/ > > > Diffs > ----- > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml c1c0169 > > Diff: https://git.reviewboard.kde.org/r/115409/diff/ > > > Testing > ------- > > Has some minor glitches, please see bugreport. > > > Thanks, > > Kai Uwe Broulik > > --===============7339206155156458779== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/

On March 7th, 2014, 12:19 p.m. UTC, Christoph Feck wrote:

plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml (Diff revision 1)
75	onDataChanged: {

Removal of this causes two other regressions: bug 331797, bug 331831.

I re-added the "onDataChanged:" handling and both bugs are gone, but I only have a single battery, so I cannot test if bug 324847 is still fixed.

On March 7th, 2014, 3:38 p.m. UTC, Kai Uwe Broulik wrote:

Sorry for the inconvenience :-(

Will try to test your patch [1] tomorrow.

[1] http://bugsfiles.kde.org/attachment.cgi?id=85464

On March 7th, 2014, 6:48 p.m. UTC, Christoph Feck wrote:

Don't worry :) The regressions are minor, and to be honest, I would prefer  to not commit my patch, unless we find a way to get both bug 321823 and the regressions fixed.

On March 10th, 2014, 6:23 p.m. UTC, Kai Uwe Broulik wrote:

Just tested it, plugged in and out my mouse multiple times and it appears and re-appears, and also the tooltip (which is reported broken in Bug 324847 Comment 19) seems properly updated.

Go ahead and push it, thanks for taking care of this! :-)

On March 11th, 2014, 12:15 a.m. UTC, Christoph Feck wrote:

But then we would get bug 321823 again...

I think showing wrong brightness (0%) is worse than the auto-closing popup with Ac plugged in and battery charged and the thing hidden in the popup.
I'm seeing a lot of posts about this regression on G+ and other sources lately.
So, please push. :/

Plasma Next should fix the Bug 321823 for us at least I guess.

- Kai Uwe

On February 15th, 2014, 10:19 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma, Solid and Sebastian Kügler.

By Kai Uwe Broulik.

Updated Feb. 15, 2014, 10:19 p.m.

Bugs: 324847

Repository: kde-workspace

Description

For some reason when a new battery appears (eg. mouse plugged in), the battery does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer, however.
I am really clueless on to what causes this, so I just throw this patch in for enlightenment as it sort of makes it work. :/

Testing

Has some minor glitches, please see bugreport.

Diffs

plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml (c1c0169)

--===============7339206155156458779==-- --===============6784467055082856658== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6784467055082856658==--