This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/

On March 7th, 2014, 12:19 p.m. UTC, Christoph Feck wrote:

plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml (Diff revision 1)
75
        onDataChanged: {
Removal of this causes two other regressions: bug 331797, bug 331831.

I re-added the "onDataChanged:" handling and both bugs are gone, but I only have a single battery, so I cannot test if bug 324847 is still fixed.

On March 7th, 2014, 3:38 p.m. UTC, Kai Uwe Broulik wrote:

Sorry for the inconvenience :-(

Will try to test your patch [1] tomorrow.

[1] http://bugsfiles.kde.org/attachment.cgi?id=85464

On March 7th, 2014, 6:48 p.m. UTC, Christoph Feck wrote:

Don't worry :) The regressions are minor, and to be honest, I would prefer  to not commit my patch, unless we find a way to get both bug 321823 and the regressions fixed.

On March 10th, 2014, 6:23 p.m. UTC, Kai Uwe Broulik wrote:

Just tested it, plugged in and out my mouse multiple times and it appears and re-appears, and also the tooltip (which is reported broken in Bug 324847 Comment 19) seems properly updated.

Go ahead and push it, thanks for taking care of this! :-)

On March 11th, 2014, 12:15 a.m. UTC, Christoph Feck wrote:

But then we would get bug 321823 again...
I think showing wrong brightness (0%) is worse than the auto-closing popup with Ac plugged in and battery charged and the thing hidden in the popup.
I'm seeing a lot of posts about this regression on G+ and other sources lately.
So, please push. :/

Plasma Next should fix the Bug 321823 for us at least I guess.

- Kai Uwe


On February 15th, 2014, 10:19 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma, Solid and Sebastian Kügler.
By Kai Uwe Broulik.

Updated Feb. 15, 2014, 10:19 p.m.

Bugs: 324847
Repository: kde-workspace

Description

For some reason when a new battery appears (eg. mouse plugged in), the battery does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer, however.
I am really clueless on to what causes this, so I just throw this patch in for enlightenment as it sort of makes it work. :/

Testing

Has some minor glitches, please see bugreport.

Diffs

  • plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml (c1c0169)

View Diff