[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116460: Footer clock fix
From:       Bhushan Shah <bhush94 () gmail ! com>
Date:       2014-02-28 14:30:47
Message-ID: CAGPcNU0a-vFVPd4+Q2uzZrwFwC3CL8pz3Bz8G8OO+Dy5T7zewg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hey,

On Fri, Feb 28, 2014 at 7:04 PM, Maulik Kotadia <maulikkotadia@gmail.com>wrote:

> Hi,
> First of all apologies for the mistakes . I've started contributing to KDE
> very recently and it was my first patch. I'll keep this thing in mind in
> future.
>
> -
> Thanks & Regards
>
However its easy fix.. just remove timer code and set text property of the
headerTimeText to relevant Qt.formatDateTime call.

Regards!

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra">Hey,</div><div class="gmail_extra"><br><div \
class="gmail_quote">On Fri, Feb 28, 2014 at 7:04 PM, Maulik Kotadia <span \
dir="ltr">&lt;<a href="mailto:maulikkotadia@gmail.com" \
target="_blank">maulikkotadia@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><p \
dir="ltr">Hi,<br> First of all apologies for the mistakes . I&#39;ve started \
contributing to KDE very recently and it was my first patch. I&#39;ll keep this thing \
in mind in future. </p> <p dir="ltr">-<br>
Thanks &amp; Regards</p></blockquote><div style>However its easy fix.. just remove \
timer code and set text property of the headerTimeText to relevant Qt.formatDateTime \
call.</div><div style><br></div><div style>Regards!</div> </div><div><br></div>-- \
<br>Bhushan Shah<br><br><a href="http://bhush9.github.io" \
target="_blank">http://bhush9.github.io</a><br>IRC Nick : bshah on Freenode<br> \
</div></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]