[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116460: Footer clock fix
From:       Maulik Kotadia <maulikkotadia () gmail ! com>
Date:       2014-02-28 13:46:05
Message-ID: CABgkYUprwNOwfn+ZTenwrAgW4BiCoUfk_b_PV=DwhtqRDeZgJA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,
First of all apologies for the mistakes . I've started contributing to KDE
very recently and it was my first patch. I'll keep this thing in mind in
future.

-
Thanks & Regards
Maulik Kotadia
On 28 Feb 2014 02:42, "Maulik Kotadia" <maulikkotadia@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116460/
>   Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny
> Kumari.
> By Maulik Kotadia.
>  *Repository: * plasma-mediacenter
> Description
>
> The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM
>
>   Testing
>
> I've tested the diff and its working correctly
>
>   Diffs
>
>    - mediaelements/mediawelcome/HomeScreenFooter.qml (d2c0eb7)
>
> View Diff <https://git.reviewboard.kde.org/r/116460/diff/>
>

[Attachment #5 (text/html)]

<p dir="ltr">Hi,<br>
First of all apologies for the mistakes . I&#39;ve started contributing to KDE very \
recently and it was my first patch. I&#39;ll keep this thing in mind in future. </p> \
<p dir="ltr">-<br> Thanks &amp; Regards<br>
Maulik Kotadia</p>
<div class="gmail_quote">On 28 Feb 2014 02:42, &quot;Maulik Kotadia&quot; &lt;<a \
href="mailto:maulikkotadia@gmail.com">maulikkotadia@gmail.com</a>&gt; wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">




 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116460/" \
target="_blank">https://git.reviewboard.kde.org/r/116460/</a>  </td>
    </tr>
   </table>
   <br>




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url(&#39;https://git.reviewboard.kde.org/static/rb/images/revi \
ew_request_box_top_bg.ab6f3b1072c9.png&#39;);background-repeat:repeat-x;border:1px \
black solid">

 <tr>
  <td>

<div>Review request for Plasma, R.Harish  Navnit, Shantanu Tushar, and Sinny \
Kumari.</div> <div>By Maulik Kotadia.</div>










<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
plasma-mediacenter
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">The \
footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 \
AM </pre>

  </td>
 </tr>
</table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I&#39;ve \
tested the diff and its working correctly</pre>  </td>
 </tr>
</table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>mediaelements/mediawelcome/HomeScreenFooter.qml <span \
style="color:grey">(d2c0eb7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116460/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </div>


</blockquote></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]