[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116460: Footer clock fix
From: "R.Harish Navnit" <harishnavnit () gmail ! com>
Date: 2014-02-28 15:48:20
Message-ID: CADBhiF3N5EJ4wCZrVNcoGP255io1HQhpLZ=8xwB2TqeUk6FH6Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Maulik,
Let me try to elaborate what's being mentioned here, just in case things
weren't clear( I had to discuss the issue with sebas later on in the IRC to
really get a grip of what was going here).
On Fri, Feb 28, 2014 at 6:41 PM, Sebastian K=FCgler <sebas@kde.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116460/
>
> This fix is wrong, it's merely trying to handle a symptom. The root cause=
of this erratic behavior is that we're making up our own time formatting c=
ode.
>
> The time format in the place where you and I live(assuming India) is in
AM/PM, but is not necessarily the same elsewhere. I too had sent(as sebas
mentioned) the a patch not considering the differing time formats in
different locations. That has to be taken care of :)
> The right approach would entail:
>
> - Getting the right timezone (The time dataengine knows it)
> - Using a correct timeformatting function, such as Qt.formatDateTime or o=
ne in the org.kde.klocale import (as Bhushan notes)
>
>
> There is already a review request for this, you've probably seen it as yo=
u've CC:ed the author of that patch. You should, however, also have read th=
e comments, as this "solution" is the exact same as in that patch. I'm not =
sure what's going on here, but you should try not to step on each others to=
es.
>
> Thanks for mentioning that :) I'm also working on the fix for the same
issue :P
Cheers
Thanking You,
R.Harish Navnit
The Enigma <http://harishnavnit.wordpress.com/>
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra">Hi Maulik,</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Let me try to elaborate \
what's being mentioned here, just in case things weren't clear( I had to \
discuss the issue with sebas later on in the IRC to really get a grip of what was \
going here).</div>
<div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 28, 2014 at 6:41 \
PM, Sebastian Kügler <span dir="ltr"><<a href="mailto:sebas@kde.org" \
target="_blank">sebas@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-le \
ft:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,sans-serif"><div>
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" \
style="border-top-width:1px;border-right-width:1px;border-bottom-width:1px;border-left \
-width:1px;border-top-color:rgb(201,195,153);border-right-color:rgb(201,195,153);borde \
r-bottom-color:rgb(201,195,153);border-left-color:rgb(201,195,153);border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116460/" \
target="_blank">https://git.reviewboard.kde.org/r/116460/</a> </td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;word-wrap:break-word">This fix is wrong, \
it's merely trying to handle a symptom. The root cause of this erratic behavior \
is that we're making up our own time formatting code.</pre>
</div></div></blockquote><div>The time format in the place where you and I \
live(assuming India) is in AM/PM, but is not necessarily the same elsewhere. I too \
had sent(as sebas mentioned) the a patch not considering the differing time formats \
in different locations. That has to be taken care of :)</div> <blockquote \
class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-le \
ft:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><pre \
style="white-space:pre-wrap;word-wrap:break-word"> The right approach would entail:
- Getting the right timezone (The time dataengine knows it)
- Using a correct timeformatting function, such as Qt.formatDateTime or one in the \
org.kde.klocale import (as Bhushan notes)
There is already a review request for this, you've probably seen it as you've \
CC:ed the author of that patch. You should, however, also have read the comments, as \
this "solution" is the exact same as in that patch. I'm not sure \
what's going on here, but you should try not to step on each others toes.</pre> \
</div></div></blockquote><div>Thanks for mentioning that :) I'm also working on \
the fix for the same issue :P</div><div><br></div><div><br></div><div>Cheers \
</div><div><br></div><div><div dir="ltr"><div>Thanking You,<br> R.Harish \
Navnit<br></div><a href="http://harishnavnit.wordpress.com/" target="_blank">The \
Enigma</a><br></div></div><div><br></div></div> </div></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic