[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-01-30 15:16:11
Message-ID: 20140130151611.32672.65574 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113697/#review48631
-----------------------------------------------------------
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml
<https://git.reviewboard.kde.org/r/113697/#comment34347>
change to:
if (buttonRow.showAccel && alt)
alt should still be set in the KeyEvent
(from the docs)
This property holds the keyboard modifier flags that existed immediately before \
the event occurred.
rationale:
if you press alt then shift, then release shift you don't want to reset the \
focus.
- David Edmundson
On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113697/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 12:27 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 314720, 316084, 319935, and 324821
> http://bugs.kde.org/show_bug.cgi?id=314720
> http://bugs.kde.org/show_bug.cgi?id=316084
> http://bugs.kde.org/show_bug.cgi?id=319935
> http://bugs.kde.org/show_bug.cgi?id=324821
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> The focus is being stolen from the input field when alt is being pressed in order \
> to make it possible to use keyboard to do unlocking. Unfortunately this causes the \
> focus never to be returned to the input field.
> This fixes at least 314720, but perhaps other similar bugs such as 324821 too. \
> 324821 is also partially related.
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
> 66a3bb4
> Diff: https://git.reviewboard.kde.org/r/113697/diff/
>
>
> Testing
> -------
>
> Tested on recent git installation.
>
>
> Thanks,
>
> Teemu Rytilahti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113697/">https://git.reviewboard.kde.org/r/113697/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/113697/diff/2/?file=220650#file220650line162" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">162</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="nx">buttonRow</span><span \
class="p">.</span><span class="nx">showAccel</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">change to: \
if (buttonRow.showAccel && alt)
alt should still be set in the KeyEvent
(from the docs)
This property holds the keyboard modifier flags that existed immediately before the \
event occurred.
rationale:
if you press alt then shift, then release shift you don't want to reset the \
focus.
</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On November 27th, 2013, 12:27 a.m. UTC, Teemu Rytilahti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Teemu Rytilahti.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 12:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314720">314720</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316084">316084</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=319935">319935</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=324821">324821</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The focus is being stolen from the input field when alt is being pressed \
in order to make it possible to use keyboard to do unlocking. Unfortunately this \
causes the focus never to be returned to the input field.
This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 \
is also partially related.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on recent git installation.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(66a3bb4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113697/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic