[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
From: "Teemu Rytilahti" <tpr () iki ! fi>
Date: 2013-11-27 0:48:49
Message-ID: 20131127004849.1924.3392 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote:
> > I'm not actually sure whether is okay to force focus after any key is being \
> > released...
>
> Christoph Feck wrote:
> Bug 319935 is probably the same issue, and also contains a patch at comment #1 for \
> the "onReleased" function, so it seems there is no other way to fix it.
> Teemu Rytilahti wrote:
> Yup, seems to be the same there, added to the list.
>
> Christoph Feck wrote:
> Teemu, if there are no objections within the next three days, please commit it to \
> 4.11 branch.
> Christoph Feck wrote:
> If I understand your recent message on #plasma correctly, you found issues with the \
> current patch. Could you add a comment with your findings, discard the request, or \
> update it with an updated patch?
Added the updated patch, which checks if the accelerators are shown and forces the \
focus if they are on onReleased.
- Teemu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113697/#review43193
-----------------------------------------------------------
On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113697/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 12:27 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 314720, 316084, 319935, and 324821
> http://bugs.kde.org/show_bug.cgi?id=314720
> http://bugs.kde.org/show_bug.cgi?id=316084
> http://bugs.kde.org/show_bug.cgi?id=319935
> http://bugs.kde.org/show_bug.cgi?id=324821
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> The focus is being stolen from the input field when alt is being pressed in order \
> to make it possible to use keyboard to do unlocking. Unfortunately this causes the \
> focus never to be returned to the input field.
> This fixes at least 314720, but perhaps other similar bugs such as 324821 too. \
> 324821 is also partially related.
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
> 66a3bb4
> Diff: http://git.reviewboard.kde.org/r/113697/diff/
>
>
> Testing
> -------
>
> Tested on recent git installation.
>
>
> Thanks,
>
> Teemu Rytilahti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113697/">http://git.reviewboard.kde.org/r/113697/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 7th, 2013, 12:19 a.m. UTC, <b>Teemu \
Rytilahti</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not actually sure whether is okay to force focus after any key \
is being released...</pre> </blockquote>
<p>On November 7th, 2013, 12:23 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug 319935 is probably \
the same issue, and also contains a patch at comment #1 for the \
"onReleased" function, so it seems there is no other way to fix it.</pre> \
</blockquote>
<p>On November 7th, 2013, 12:28 a.m. UTC, <b>Teemu Rytilahti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, seems to be the \
same there, added to the list.</pre> </blockquote>
<p>On November 19th, 2013, 1:46 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Teemu, if there are no \
objections within the next three days, please commit it to 4.11 branch.</pre> \
</blockquote>
<p>On November 27th, 2013, 12:06 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I understand your \
recent message on #plasma correctly, you found issues with the current patch. Could \
you add a comment with your findings, discard the request, or update it with an \
updated patch?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added the updated patch, \
which checks if the accelerators are shown and forces the focus if they are on \
onReleased.</pre> <br />
<p>- Teemu</p>
<br />
<p>On November 27th, 2013, 12:27 a.m. UTC, Teemu Rytilahti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Teemu Rytilahti.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 12:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314720">314720</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316084">316084</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=319935">319935</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=324821">324821</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The focus is being stolen from the input field when alt is being pressed \
in order to make it possible to use keyboard to do unlocking. Unfortunately this \
causes the focus never to be returned to the input field.
This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 \
is also partially related.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on recent git installation.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(66a3bb4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113697/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic