--===============8422696134865995677== Content-Type: multipart/alternative; boundary="===============7160429047236523898==" --===============7160429047236523898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/#review48631 ----------------------------------------------------------- ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml change to: if (buttonRow.showAccel && alt) alt should still be set in the KeyEvent (from the docs) This property holds the keyboard modifier flags that existed immediately before the event occurred. rationale: if you press alt then shift, then release shift you don't want to reset the focus. - David Edmundson On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113697/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 12:27 a.m.) > > > Review request for Plasma. > > > Bugs: 314720, 316084, 319935, and 324821 > http://bugs.kde.org/show_bug.cgi?id=314720 > http://bugs.kde.org/show_bug.cgi?id=316084 > http://bugs.kde.org/show_bug.cgi?id=319935 > http://bugs.kde.org/show_bug.cgi?id=324821 > > > Repository: kde-workspace > > > Description > ------- > > The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field. > > This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 66a3bb4 > > Diff: https://git.reviewboard.kde.org/r/113697/diff/ > > > Testing > ------- > > Tested on recent git installation. > > > Thanks, > > Teemu Rytilahti > > --===============7160429047236523898== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/

ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml (Diff revision 2)
		162	if (buttonRow.showAccel) {

change to:
if (buttonRow.showAccel && alt)

alt should still be set in the KeyEvent

(from the docs)
This property holds the keyboard modifier flags that existed immediately before the event occurred.


rationale:
 if you press alt then shift, then release shift you don't want to reset the focus.

- David Edmundson

On November 27th, 2013, 12:27 a.m. UTC, Teemu Rytilahti wrote:

Review request for Plasma.

By Teemu Rytilahti.

Updated Nov. 27, 2013, 12:27 a.m.

Bugs: 314720, 316084, 319935, 324821

Repository: kde-workspace

Description

The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field.

This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related.

Testing

Tested on recent git installation.

Diffs

ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml (66a3bb4)

--===============7160429047236523898==-- --===============8422696134865995677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8422696134865995677==--