--===============4879776100612174231== Content-Type: multipart/alternative; boundary="===============3486264882778485557==" --===============3486264882778485557== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at comment #1 for the "onReleased" function, so it seems there is no other way to fix it. > > Teemu Rytilahti wrote: > Yup, seems to be the same there, added to the list. > > Christoph Feck wrote: > Teemu, if there are no objections within the next three days, please commit it to 4.11 branch. > > Christoph Feck wrote: > If I understand your recent message on #plasma correctly, you found issues with the current patch. Could you add a comment with your findings, discard the request, or update it with an updated patch? Added the updated patch, which checks if the accelerators are shown and forces the focus if they are on onReleased. - Teemu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/#review43193 ----------------------------------------------------------- On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113697/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 12:27 a.m.) > > > Review request for Plasma. > > > Bugs: 314720, 316084, 319935, and 324821 > http://bugs.kde.org/show_bug.cgi?id=314720 > http://bugs.kde.org/show_bug.cgi?id=316084 > http://bugs.kde.org/show_bug.cgi?id=319935 > http://bugs.kde.org/show_bug.cgi?id=324821 > > > Repository: kde-workspace > > > Description > ------- > > The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field. > > This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 66a3bb4 > > Diff: http://git.reviewboard.kde.org/r/113697/diff/ > > > Testing > ------- > > Tested on recent git installation. > > > Thanks, > > Teemu Rytilahti > > --===============3486264882778485557== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/

On November 7th, 2013, 12:19 a.m. UTC, Teemu Rytilahti wrote:
I'm not actually sure whether is okay to force focus after any key is being released...
On November 7th, 2013, 12:23 a.m. UTC, Christoph Feck wrote:
Bug 319935 is probably the same issue, and also contains a patch at comment #1 for the "onReleased" function, so it seems there is no other way to fix it.
On November 7th, 2013, 12:28 a.m. UTC, Teemu Rytilahti wrote:
Yup, seems to be the same there, added to the list.
On November 19th, 2013, 1:46 a.m. UTC, Christoph Feck wrote:
Teemu, if there are no objections within the next three days, please commit it to 4.11 branch.
On November 27th, 2013, 12:06 a.m. UTC, Christoph Feck wrote:
If I understand your recent message on #plasma correctly, you found issues with the current patch. Could you add a comment with your findings, discard the request, or update it with an updated patch?

Added the updated patch, which checks if the accelerators are shown and forces the focus if they are on onReleased.

- Teemu

On November 27th, 2013, 12:27 a.m. UTC, Teemu Rytilahti wrote:

Review request for Plasma.

By Teemu Rytilahti.

Updated Nov. 27, 2013, 12:27 a.m.

Bugs: 314720, 316084, 319935, 324821

Repository: kde-workspace

Description

The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field.

This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related.

Testing

Tested on recent git installation.

Diffs

ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml (66a3bb4)

--===============3486264882778485557==-- --===============4879776100612174231== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4879776100612174231==--