'Re: Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-10-21 20:39:29
Message-ID: 20131021203929.24100.4642 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113345/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 8:39 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

Removes the find_package(Qt5Transitional) and does the proper find_package(Qt5) with the list of modules.

Most of the porting is about using the Qt5:: targets.

Diffs
-----

  CMakeLists.txt e00139f 
  examples/kpart/CMakeLists.txt 94597a9 
  examples/runner/CMakeLists.txt 3aaaedd 
  src/declarativeimports/calendar/CMakeLists.txt c27b076 
  src/declarativeimports/calendar/calendar.cpp 3893751 
  src/declarativeimports/core/CMakeLists.txt 732f348 
  src/declarativeimports/core/tests/CMakeLists.txt 974e8bb 
  src/declarativeimports/draganddrop/CMakeLists.txt fa1f7f5 
  src/declarativeimports/locale/CMakeLists.txt 35d9407 
  src/declarativeimports/plasmacomponents/CMakeLists.txt 197fa6a 
  src/declarativeimports/qtextracomponents/CMakeLists.txt 3dfd419 
  src/declarativeimports/qtextracomponents/tests/CMakeLists.txt 0799123 
  src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp 9e512b5 
  src/plasma/autotests/CMakeLists.txt 1b8dbd5 
  src/plasma/tests/testcontainmentactionsplugin/CMakeLists.txt af1ba9c 
  src/platformstatus/CMakeLists.txt cb8fca8 
  src/scriptengines/javascript/CMakeLists.txt b339bbc 

Diff: http://git.reviewboard.kde.org/r/113345/diff/

Testing
-------

Builds, tests still pass.

Thanks,

Aleix Pol Gonzalez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113345/">http://git.reviewboard.kde.org/r/113345/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2013, 8:39 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removes the find_package(Qt5Transitional) and does the proper \
find_package(Qt5) with the list of modules.

Most of the porting is about using the Qt5:: targets.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds, tests still pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(e00139f)</span></li>

 <li>examples/kpart/CMakeLists.txt <span style="color: grey">(94597a9)</span></li>

 <li>examples/runner/CMakeLists.txt <span style="color: grey">(3aaaedd)</span></li>

 <li>src/declarativeimports/calendar/CMakeLists.txt <span style="color: \
grey">(c27b076)</span></li>

 <li>src/declarativeimports/calendar/calendar.cpp <span style="color: \
grey">(3893751)</span></li>

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(732f348)</span></li>

 <li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: \
grey">(974e8bb)</span></li>

 <li>src/declarativeimports/draganddrop/CMakeLists.txt <span style="color: \
grey">(fa1f7f5)</span></li>

 <li>src/declarativeimports/locale/CMakeLists.txt <span style="color: \
grey">(35d9407)</span></li>

 <li>src/declarativeimports/plasmacomponents/CMakeLists.txt <span style="color: \
grey">(197fa6a)</span></li>

 <li>src/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: \
grey">(3dfd419)</span></li>

 <li>src/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span \
style="color: grey">(0799123)</span></li>

 <li>src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp <span \
style="color: grey">(9e512b5)</span></li>

 <li>src/plasma/autotests/CMakeLists.txt <span style="color: \
grey">(1b8dbd5)</span></li>

 <li>src/plasma/tests/testcontainmentactionsplugin/CMakeLists.txt <span style="color: \
grey">(af1ba9c)</span></li>

 <li>src/platformstatus/CMakeLists.txt <span style="color: \
grey">(cb8fca8)</span></li>

 <li>src/scriptengines/javascript/CMakeLists.txt <span style="color: \
grey">(b339bbc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113345/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 