From kde-panel-devel Mon Oct 21 20:39:29 2013 From: "Aleix Pol Gonzalez" Date: Mon, 21 Oct 2013 20:39:29 +0000 To: kde-panel-devel Subject: Re: Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks Message-Id: <20131021203929.24100.4642 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138238799705357 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1025105200159941822==" --===============1025105200159941822== Content-Type: multipart/alternative; boundary="===============2412945651214004670==" --===============2412945651214004670== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113345/ ----------------------------------------------------------- (Updated Oct. 21, 2013, 8:39 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- Removes the find_package(Qt5Transitional) and does the proper find_package(Qt5) with the list of modules. Most of the porting is about using the Qt5:: targets. Diffs ----- CMakeLists.txt e00139f examples/kpart/CMakeLists.txt 94597a9 examples/runner/CMakeLists.txt 3aaaedd src/declarativeimports/calendar/CMakeLists.txt c27b076 src/declarativeimports/calendar/calendar.cpp 3893751 src/declarativeimports/core/CMakeLists.txt 732f348 src/declarativeimports/core/tests/CMakeLists.txt 974e8bb src/declarativeimports/draganddrop/CMakeLists.txt fa1f7f5 src/declarativeimports/locale/CMakeLists.txt 35d9407 src/declarativeimports/plasmacomponents/CMakeLists.txt 197fa6a src/declarativeimports/qtextracomponents/CMakeLists.txt 3dfd419 src/declarativeimports/qtextracomponents/tests/CMakeLists.txt 0799123 src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp 9e512b5 src/plasma/autotests/CMakeLists.txt 1b8dbd5 src/plasma/tests/testcontainmentactionsplugin/CMakeLists.txt af1ba9c src/platformstatus/CMakeLists.txt cb8fca8 src/scriptengines/javascript/CMakeLists.txt b339bbc Diff: http://git.reviewboard.kde.org/r/113345/diff/ Testing ------- Builds, tests still pass. Thanks, Aleix Pol Gonzalez --===============2412945651214004670== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113345/

This change has been marked as submitted.

Review request for Plasma.
By Aleix Pol Gonzalez.

Updated Oct. 21, 2013, 8:39 p.m.

Repository: plasma-framework

Description 

Removes the find_package(Qt5Transitional) and does the proper find_package(Qt5) with the list of modules.

Most of the porting is about using the Qt5:: targets.

Testing 

Builds, tests still pass.

Diffs

  • CMakeLists.txt (e00139f)
  • examples/kpart/CMakeLists.txt (94597a9)
  • examples/runner/CMakeLists.txt (3aaaedd)
  • src/declarativeimports/calendar/CMakeLists.txt (c27b076)
  • src/declarativeimports/calendar/calendar.cpp (3893751)
  • src/declarativeimports/core/CMakeLists.txt (732f348)
  • src/declarativeimports/core/tests/CMakeLists.txt (974e8bb)
  • src/declarativeimports/draganddrop/CMakeLists.txt (fa1f7f5)
  • src/declarativeimports/locale/CMakeLists.txt (35d9407)
  • src/declarativeimports/plasmacomponents/CMakeLists.txt (197fa6a)
  • src/declarativeimports/qtextracomponents/CMakeLists.txt (3dfd419)
  • src/declarativeimports/qtextracomponents/tests/CMakeLists.txt (0799123)
  • src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp (9e512b5)
  • src/plasma/autotests/CMakeLists.txt (1b8dbd5)
  • src/plasma/tests/testcontainmentactionsplugin/CMakeLists.txt (af1ba9c)
  • src/platformstatus/CMakeLists.txt (cb8fca8)
  • src/scriptengines/javascript/CMakeLists.txt (b339bbc)

View Diff
--===============2412945651214004670==-- --===============1025105200159941822== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1025105200159941822==--