[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi
From: "Jacopo De Simoi" <wilderkde () gmail ! com>
Date: 2013-09-28 19:15:40
Message-ID: 20130928191540.32047.38912 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 28, 2013, 1:59 a.m., Jacopo De Simoi wrote:
> > Let me have a look at the patch; I'll be able to do it tomorrow and commit it \
> > myself if it is ok.
> > Thanks
> >
> > __J
> > Device notifier mantainer
Ok, even with the patch, within any given category (e.g. Storage Volume) devices are \
sorted in essentially random order (that is, the population order of the engine), so \
the patch is not addressing that issue. On the other hand it surely helps a lot to \
have Network devices and Storage Volumes separated in the list when showing only \
non-removable devices. I still believe it is useful to have removable devices show \
up on top of other ones when showing all devices, so I am not convinced of changing \
the sort-order in this case.
I would therefore change the sort order only if showing "non-removable devices only" \
and I am willing to commit this change if it is ok with the author.
Still, a true solution is still to be found, so I'd rather not close the bug quite \
yet.
- Jacopo De
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112812/#review40934
-----------------------------------------------------------
On Sept. 19, 2013, 3:24 p.m., Benedikt Gollatz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112812/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2013, 3:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Use type description sort order in the devicenotifier applet when non-removable \
> devices are configured to be displayed. This avoids apparently random sort order \
> (by device engine population timestamp) and unneccessary ListView sections. The \
> problem becomes apparent if other types of devices besides simple storage volumes \
> are configured in /etc/fstab, like for example network mounts.
> Fixes bug #324459.
>
>
> This addresses bug 324459.
> http://bugs.kde.org/show_bug.cgi?id=324459
>
>
> Diffs
> -----
>
> plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
> 9b6132e
> Diff: http://git.reviewboard.kde.org/r/112812/diff/
>
>
> Testing
> -------
>
> Works for me using KDE 4.10.5 packaged with Fedora 19.
>
>
> Thanks,
>
> Benedikt Gollatz
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112812/">http://git.reviewboard.kde.org/r/112812/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2013, 1:59 a.m. UTC, <b>Jacopo \
De Simoi</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let me have a look at the patch; I'll be able to do it tomorrow and \
commit it myself if it is ok.
Thanks
__J
Device notifier mantainer</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, even with the patch, \
within any given category (e.g. Storage Volume) devices are sorted in essentially \
random order (that is, the population order of the engine), so the patch is not \
addressing that issue. On the other hand it surely helps a lot to have Network \
devices and Storage Volumes separated in the list when showing only non-removable \
devices. I still believe it is useful to have removable devices show up on top of \
other ones when showing all devices, so I am not convinced of changing the sort-order \
in this case.
I would therefore change the sort order only if showing "non-removable devices only" \
and I am willing to commit this change if it is ok with the author.
Still, a true solution is still to be found, so I'd rather not close the bug \
quite yet.
</pre>
<br />
<p>- Jacopo De</p>
<br />
<p>On September 19th, 2013, 3:24 p.m. UTC, Benedikt Gollatz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Benedikt Gollatz.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 3:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use type description sort order in the devicenotifier applet when \
non-removable devices are configured to be displayed. This avoids apparently random \
sort order (by device engine population timestamp) and unneccessary ListView \
sections. The problem becomes apparent if other types of devices besides simple \
storage volumes are configured in /etc/fstab, like for example network mounts.
Fixes bug #324459.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me using KDE 4.10.5 packaged with Fedora 19.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324459">324459</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(9b6132e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112812/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic