This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112812/ |
On September 28th, 2013, 1:59 a.m. UTC, Jacopo De Simoi wrote:
Let me have a look at the patch; I'll be able to do it tomorrow and commit it myself if it is ok. Thanks __J Device notifier mantainer
Ok, even with the patch, within any given category (e.g. Storage Volume) devices are sorted in essentially random order (that is, the population order of the engine), so the patch is not addressing that issue. On the other hand it surely helps a lot to have Network devices and Storage Volumes separated in the list when showing only non-removable devices. I still believe it is useful to have removable devices show up on top of other ones when showing all devices, so I am not convinced of changing the sort-order in this case. I would therefore change the sort order only if showing “non-removable devices only” and I am willing to commit this change if it is ok with the author. Still, a true solution is still to be found, so I'd rather not close the bug quite yet.
- Jacopo De
On September 19th, 2013, 3:24 p.m. UTC, Benedikt Gollatz wrote:
Review request for Plasma.
By Benedikt Gollatz.
Updated Sept. 19, 2013, 3:24 p.m. Description
Testing
Bugs:
324459
Diffs
|