From kde-panel-devel Sat Sep 28 19:15:40 2013 From: "Jacopo De Simoi" Date: Sat, 28 Sep 2013 19:15:40 +0000 To: kde-panel-devel Subject: Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi Message-Id: <20130928191540.32047.38912 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138039576400672 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3045777453844427729==" --===============3045777453844427729== Content-Type: multipart/alternative; boundary="===============3911138718287811700==" --===============3911138718287811700== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Sept. 28, 2013, 1:59 a.m., Jacopo De Simoi wrote: > > Let me have a look at the patch; I'll be able to do it tomorrow and commit it myself if it is ok. > > > > Thanks > > > > __J > > Device notifier mantainer Ok, even with the patch, within any given category (e.g. Storage Volume) devices are sorted in essentially random order (that is, the population order of the engine), so the patch is not addressing that issue. On the other hand it surely helps a lot to have Network devices and Storage Volumes separated in the list when showing only non-removable devices. I still believe it is useful to have removable devices show up on top of other ones when showing all devices, so I am not convinced of changing the sort-order in this case. I would therefore change the sort order only if showing “non-removable devices only” and I am willing to commit this change if it is ok with the author. Still, a true solution is still to be found, so I'd rather not close the bug quite yet. - Jacopo De ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112812/#review40934 ----------------------------------------------------------- On Sept. 19, 2013, 3:24 p.m., Benedikt Gollatz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112812/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 3:24 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Use type description sort order in the devicenotifier applet when non-removable devices are configured to be displayed. This avoids apparently random sort order (by device engine population timestamp) and unneccessary ListView sections. The problem becomes apparent if other types of devices besides simple storage volumes are configured in /etc/fstab, like for example network mounts. > > Fixes bug #324459. > > > This addresses bug 324459. > http://bugs.kde.org/show_bug.cgi?id=324459 > > > Diffs > ----- > > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e > > Diff: http://git.reviewboard.kde.org/r/112812/diff/ > > > Testing > ------- > > Works for me using KDE 4.10.5 packaged with Fedora 19. > > > Thanks, > > Benedikt Gollatz > > --===============3911138718287811700== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112812/

On September 28th, 2013, 1:59 a.m. UTC, Jacopo De Simoi wrote:
Let me have a look at the patch; I'll be able to do it tomorrow and commit it myself if it is ok. 

Thanks

__J 
Device notifier mantainer

Ok, even with the patch, within any given category (e.g. Storage Volume) devices are sorted in essentially random order (that is, the population order of the engine), so the patch is not addressing that issue.  On the other hand it surely helps a lot to have Network devices and Storage Volumes separated in the list when showing only non-removable devices.  
I still believe it is useful to have removable devices show up on top of other ones when showing all devices, so I am not convinced of changing the sort-order in this case. 

I would therefore change the sort order only if showing “non-removable devices only” and I am willing to commit this change if it is ok with the author. 

Still, a true solution is still to be found, so I'd rather not close the bug quite yet.

- Jacopo De

On September 19th, 2013, 3:24 p.m. UTC, Benedikt Gollatz wrote:

Review request for Plasma.

By Benedikt Gollatz.

Updated Sept. 19, 2013, 3:24 p.m.

Description

Use type description sort order in the devicenotifier applet when non-removable devices are configured to be displayed. This avoids apparently random sort order (by device engine population timestamp) and unneccessary ListView sections. The problem becomes apparent if other types of devices besides simple storage volumes are configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.

Testing

Works for me using KDE 4.10.5 packaged with Fedora 19.

Bugs: 324459

Diffs

plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml (9b6132e)

--===============3911138718287811700==-- --===============3045777453844427729== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3045777453844427729==--