[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112073: Partially revert commit 83d3018
From: "Cedric Bellegarde" <gnumdk () gmail ! com>
Date: 2013-08-20 10:40:24
Message-ID: 20130820104024.20422.2406 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 19, 2013, 9:10 a.m., David Faure wrote:
> > This is ... extremely surprising.
> > plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? That's \
> > what "unique" expects (while "multi" expects the PID appended).
> > In addition, I didn't experience any problems with startup and the splash \
> > screen...
> > Are you really sure this change fixes anything? I could be wrong, but I'm rather \
> > surprised.
>
> Hrvoje Senjan wrote:
> Yes, see https://bugs.kde.org/show_bug.cgi?id=321695#c13 and c17. Or in c5 and c6 \
> there's confirmation restoring to "wait" also works as expected/as was before. (In \
> comment 2 there's video which illustrates the issue clearly). I've validated the \
> issue and the "fix" also myself on two installs. Tbh, i have also no idea why it \
> breaks it, but looks it does...
Can confirm issue too and this patch fix it.
- Cedric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38112
-----------------------------------------------------------
On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 12:01 a.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Description
> -------
>
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
>
>
> This addresses bug 321695.
> http://bugs.kde.org/show_bug.cgi?id=321695
>
>
> Diffs
> -----
>
> plasma/desktop/shell/data/plasma-desktop.desktop f37dc57
>
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
>
>
> Testing
> -------
>
> Yes... starts "normally" as previously/ksplash isn't interupted
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112073/">http://git.reviewboard.kde.org/r/112073/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 19th, 2013, 9:10 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is ... extremely surprising. plasma-desktop registers to DBus as \
"org.kde.plasma-desktop", doesn't it? That's what \
"unique" expects (while "multi" expects the PID appended).
In addition, I didn't experience any problems with startup and the splash \
screen...
Are you really sure this change fixes anything? I could be wrong, but I'm rather \
surprised.</pre> </blockquote>
<p>On August 19th, 2013, 7:30 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, see \
https://bugs.kde.org/show_bug.cgi?id=321695#c13 and c17. Or in c5 and c6 there's \
confirmation restoring to "wait" also works as expected/as was before. (In \
comment 2 there's video which illustrates the issue clearly). I've validated \
the issue and the "fix" also myself on two installs. Tbh, i have also no \
idea why it breaks it, but looks it does...</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can confirm issue too \
and this patch fix it.</pre> <br />
<p>- Cedric</p>
<br />
<p>On August 14th, 2013, 12:01 a.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2013, 12:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While the commit may be technically correct, it breaks ksplash for 4.11 \
release... I've changed unique to multi, if there is a better solution, please \
hint it ;-) (maybe actually someone meant multi, when typing wait :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes... starts "normally" as previously/ksplash isn't \
interupted</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321695">321695</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/data/plasma-desktop.desktop <span style="color: \
grey">(f37dc57)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112073/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic