[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only sub
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-08-20 9:40:56
Message-ID: 20130820094056.29218.94933 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 17, 2013, 8:26 a.m., Marco Martin wrote:
> > Hmm, not sure about it, the packages were defined as archives with \
> > metadata.desktop in the root, this would basically allow a quirks mode, do we \
> > want to support malformed packages?
>
> Jeremy Paul Whiting wrote:
> Ok, I just tried repackaging Helium from kde-look.org with the contents directly in \
> the .tar.xz rather than in a subfolder Helium. With my other plasmapkg patch that \
> installs and uninstalls just fine. So the question then becomes are these themes on \
> kde-look.org packaged with some tool? or just packaged by hand incorrectly? If it's \
> a tool that's creating them, we ought to fix the tool, otherwise I guess I can go \
> through the themes on kde-look.org and suggest they repackage them correctly.
It's at least not possible with plasmapkg, as this tool checks for metadata.desktop, \
and only if it exists in the to-package-directory, will actually work.
I suppose it's a hand-packaged package, done wrong.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------
On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 3:06 a.m.)
>
>
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
> Sebastian Kügler.
>
> Description
> -------
>
> This is the other half of the fix for the listed bug. I made \
> Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
> archive if there's only one subdirectory for the metadata.desktop file.
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
>
>
> Diffs
> -----
>
> plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b
>
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
>
>
> Testing
> -------
>
> The bug is fixed here with this and my other patch. Any better ideas for getting \
> the only subdirectory are welcome, it feels a bit kludgy as is.
>
> Thanks,
>
> Jeremy Paul Whiting
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112129/">http://git.reviewboard.kde.org/r/112129/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 17th, 2013, 8:26 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hmm, not sure about it, the packages were defined as archives with \
metadata.desktop in the root, this would basically allow a quirks mode, do we want to \
support malformed packages?</pre> </blockquote>
<p>On August 19th, 2013, 5:06 p.m. UTC, <b>Jeremy Paul Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I just tried \
repackaging Helium from kde-look.org with the contents directly in the .tar.xz rather \
than in a subfolder Helium. With my other plasmapkg patch that installs and \
uninstalls just fine. So the question then becomes are these themes on kde-look.org \
packaged with some tool? or just packaged by hand incorrectly? If it's a tool \
that's creating them, we ought to fix the tool, otherwise I guess I can go \
through the themes on kde-look.org and suggest they repackage them correctly.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's at least not \
possible with plasmapkg, as this tool checks for metadata.desktop, and only if it \
exists in the to-package-directory, will actually work.
I suppose it's a hand-packaged package, done wrong.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On August 17th, 2013, 3:06 a.m. UTC, Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
Sebastian Kügler.</div> <div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 3:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the other half of the fix for the listed bug. I made \
Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
archive if there's only one subdirectory for the metadata.desktop file.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The bug is fixed here with this and my other patch. Any better ideas for \
getting the only subdirectory are welcome, it feels a bit kludgy as is.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479">https://bugs.kde.org/show_bug.cgi?id=149479</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/packagestructure.cpp <span style="color: \
grey">(71148e1a18227d9ca847cbffe385aaaad9c66c6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112129/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic