'Re: Review Request 112073: Partially revert commit 83d3018'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112073: Partially revert commit 83d3018
From:       "David Faure" <faure () kde ! org>
Date:       2013-08-20 11:03:08
Message-ID: 20130820110308.26748.11846 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38201
-----------------------------------------------------------

Ship it!

OK. Weird, but I don't have time to debug it. Please commit.

- David Faure

On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 12:01 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Description
> -------
> 
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
> 
> 
> This addresses bug 321695.
>     http://bugs.kde.org/show_bug.cgi?id=321695
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 
> 
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
> 
> 
> Testing
> -------
> 
> Yes... starts "normally" as previously/ksplash isn't interupted
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112073/">http://git.reviewboard.kde.org/r/112073/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. Weird, but I \
don&#39;t have time to debug it. Please commit.</pre>  <br />

<p>- David</p>

<br />
<p>On August 14th, 2013, 12:01 a.m. UTC, Hrvoje Senjan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and David Faure.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Aug. 14, 2013, 12:01 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While the commit may be technically correct, it breaks ksplash for 4.11 \
release... I&#39;ve changed unique to multi, if there is a better solution, please \
hint it ;-) (maybe actually someone meant multi, when typing wait :-)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes... starts &quot;normally&quot; as previously/ksplash isn&#39;t \
interupted</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=321695">321695</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/data/plasma-desktop.desktop <span style="color: \
grey">(f37dc57)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112073/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 