From kde-panel-devel Mon Jul 29 21:25:12 2013 From: "Mark Gaiser" Date: Mon, 29 Jul 2013 21:25:12 +0000 To: kde-panel-devel Subject: Re: Review Request 111618: Fix launcher regression, only show icons instead of icons + text Message-Id: <20130729212512.713.31207 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137513313308716 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2112659488887881255==" --===============2112659488887881255== Content-Type: multipart/alternative; boundary="===============2835721061045991711==" --===============2835721061045991711== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111618/ ----------------------------------------------------------- (Updated July 29, 2013, 9:25 p.m.) Status ------ This change has been discarded. Review request for Plasma and Eike Hein. Description ------- As described in the bug report, the launcher regressed with the move to the QML based tasks. I did my best to correct the launcher regression. The attachment shows how the launchers look with this patch. This addresses bug 321128. http://bugs.kde.org/show_bug.cgi?id=321128 Diffs ----- plasma/desktop/applets/tasks/package/contents/code/layout.js cb7a1c2 plasma/desktop/applets/tasks/package/contents/ui/Task.qml 70267fb Diff: http://git.reviewboard.kde.org/r/111618/diff/ Testing ------- Tested it and works just like it used to work in KDE 4.10. File Attachments ---------------- http://git.reviewboard.kde.org/media/uploaded/files/2013/07/20/fix_launcher.png Thanks, Mark Gaiser --===============2835721061045991711== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111618/

This change has been discarded.

Review request for Plasma and Eike Hein.
By Mark Gaiser.

Updated July 29, 2013, 9:25 p.m.

Description 

As described in the bug report, the launcher regressed with the move to the QML based tasks. I did my best to correct the launcher regression. The attachment shows how the launchers look with this patch.

Testing 

Tested it and works just like it used to work in KDE 4.10.
Bugs: 321128

Diffs

  • plasma/desktop/applets/tasks/package/contents/code/layout.js (cb7a1c2)
  • plasma/desktop/applets/tasks/package/contents/ui/Task.qml (70267fb)

View Diff

File Attachments

--===============2835721061045991711==-- --===============2112659488887881255== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2112659488887881255==--