'Re: Review Request 111087: widget-taskbar: vertical text layout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111087: widget-taskbar: vertical text layout
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2013-06-21 9:18:18
Message-ID: 20130621091818.17244.77840 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111087/#review34815
-----------------------------------------------------------

hmm, in that screenshot text looks *really* misplaced now :/

one problem is that icons don't have all the same visual center, so in any way you \
put it it will look ok for some icons, wrong for some others

- Marco Martin

On June 18, 2013, 11:44 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111087/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 11:44 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> welcome to the taskbar bug marathon ;)
> 
> this change corrects the issue reported in the report. the diff is trivial (though \
> I think the tasklabel code is silly and too complex) but I'm not sure if I can \
> approve the aesthetic consequences (see screenshot): the text moves slightly to the \
> top of the label area, but imho relative to the vertically centered icon widget it \
> looks misplaced. 
> What do you think?
> 
> 
> This addresses bug 314879.
> http://bugs.kde.org/show_bug.cgi?id=314879
> 
> 
> Diffs
> -----
> 
> plasma/desktop/applets/tasks/support/textlabel.cpp \
> 9fbc12d621c2917665fb963c0087f3a59c9e86e9  
> Diff: http://git.reviewboard.kde.org/r/111087/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
> http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png
> 
> 
> Thanks,
> 
> Greg T
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111087/">http://git.reviewboard.kde.org/r/111087/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm, in that screenshot \
text looks *really* misplaced now :/

one problem is that icons don&#39;t have all the same visual center, so in any way \
you put it it will look ok for some icons, wrong for some others</pre>  <br />

<p>- Marco</p>

<br />
<p>On June 18th, 2013, 11:44 a.m. UTC, Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated June 18, 2013, 11:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">welcome to the taskbar bug marathon ;)

this change corrects the issue reported in the report. the diff is trivial (though I \
think the tasklabel code is silly and too complex) but I&#39;m not sure if I can \
approve the aesthetic consequences (see screenshot): the text moves slightly to the \
top of the label area, but imho relative to the vertically centered icon widget it \
looks misplaced.

What do you think?</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314879">314879</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/tasks/support/textlabel.cpp <span style="color: \
grey">(9fbc12d621c2917665fb963c0087f3a59c9e86e9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111087/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png">taskbar_nocut.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 