From kde-panel-devel Fri Jun 21 09:18:18 2013 From: "Marco Martin" Date: Fri, 21 Jun 2013 09:18:18 +0000 To: kde-panel-devel Subject: Re: Review Request 111087: widget-taskbar: vertical text layout Message-Id: <20130621091818.17244.77840 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137180631009189 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8689352410675627369==" --===============8689352410675627369== Content-Type: multipart/alternative; boundary="===============3652924096122918365==" --===============3652924096122918365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111087/#review34815 ----------------------------------------------------------- hmm, in that screenshot text looks *really* misplaced now :/ one problem is that icons don't have all the same visual center, so in any way you put it it will look ok for some icons, wrong for some others - Marco Martin On June 18, 2013, 11:44 a.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111087/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 11:44 a.m.) > > > Review request for Plasma. > > > Description > ------- > > welcome to the taskbar bug marathon ;) > > this change corrects the issue reported in the report. the diff is trivial (though I think the tasklabel code is silly and too complex) but I'm not sure if I can approve the aesthetic consequences (see screenshot): the text moves slightly to the top of the label area, but imho relative to the vertically centered icon widget it looks misplaced. > > What do you think? > > > This addresses bug 314879. > http://bugs.kde.org/show_bug.cgi?id=314879 > > > Diffs > ----- > > plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d621c2917665fb963c0087f3a59c9e86e9 > > Diff: http://git.reviewboard.kde.org/r/111087/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png > > > Thanks, > > Greg T > > --===============3652924096122918365== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111087/ 

hmm, in that screenshot text looks *really* misplaced now :/

one problem is that icons don't have all the same visual center, so in any way you put it it will look ok for some icons, wrong for some others

- Marco


On June 18th, 2013, 11:44 a.m. UTC, Greg T wrote:

Review request for Plasma.
By Greg T.

Updated June 18, 2013, 11:44 a.m.

Description 

welcome to the taskbar bug marathon ;)

this change corrects the issue reported in the report. the diff is trivial (though I think the tasklabel code is silly and too complex) but I'm not sure if I can approve the aesthetic consequences (see screenshot): the text moves slightly to the top of the label area, but imho relative to the vertically centered icon widget it looks misplaced.

What do you think?
Bugs: 314879

Diffs

  • plasma/desktop/applets/tasks/support/textlabel.cpp (9fbc12d621c2917665fb963c0087f3a59c9e86e9)

View Diff

File Attachments

--===============3652924096122918365==-- --===============8689352410675627369== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8689352410675627369==--