This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111087/ 

hmm, in that screenshot text looks *really* misplaced now :/

one problem is that icons don't have all the same visual center, so in any way you put it it will look ok for some icons, wrong for some others

- Marco


On June 18th, 2013, 11:44 a.m. UTC, Greg T wrote:

Review request for Plasma.
By Greg T.

Updated June 18, 2013, 11:44 a.m.

Description 

welcome to the taskbar bug marathon ;)

this change corrects the issue reported in the report. the diff is trivial (though I think the tasklabel code is silly and too complex) but I'm not sure if I can approve the aesthetic consequences (see screenshot): the text moves slightly to the top of the label area, but imho relative to the vertically centered icon widget it looks misplaced.

What do you think?
Bugs: 314879

Diffs

  • plasma/desktop/applets/tasks/support/textlabel.cpp (9fbc12d621c2917665fb963c0087f3a59c9e86e9)

View Diff

File Attachments