[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Reusable qml components for mediabrowsing
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2012-12-23 14:10:40
Message-ID: 20121223141040.15392.92796 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107861/#review23907
-----------------------------------------------------------
Ship it!
Ship It!
components/MediaGridItemDelegate.qml
<http://git.reviewboard.kde.org/r/107861/#comment18232>
will this not be used? If yes, remove it
- Shantanu Tushar
On Dec. 23, 2012, 8:33 a.m., Fabian Riethmayer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107861/
> -----------------------------------------------------------
> =
> (Updated Dec. 23, 2012, 8:33 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> First reusable qml components for mediabrowsing.
> Description of the browsers http://community.kde.org/Plasma/Plasma_Media_=
Center/Media_Browser
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt f7f2366 =
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccom=
ponents/MediaBrowser.qml a66123e =
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccom=
ponents/qmldir 3f2f55d =
> components/CMakeLists.txt PRE-CREATION =
> components/MediaGridBrowser.qml PRE-CREATION =
> components/MediaGridItemDelegate.qml PRE-CREATION =
> components/MediaItemDelegateLogic.js PRE-CREATION =
> components/MediaLineItemDelegate.qml PRE-CREATION =
> components/MediaListBrowser.qml PRE-CREATION =
> components/TabBrowser.qml PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/107861/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Fabian Riethmayer
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107861/">http://git.reviewboard.kde.org/r/107861/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107861/diff/1/?file=100686#file100686line240" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/MediaGridItemDelegate.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">240</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> /*if \
(url) {</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">241</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
eventParams.url = url</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">242</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
}*/</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">will this \
not be used? If yes, remove it</pre> </div>
<br />
<p>- Shantanu</p>
<br />
<p>On December 23rd, 2012, 8:33 a.m., Fabian Riethmayer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Fabian Riethmayer.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2012, 8:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First reusable qml components for mediabrowsing. Description of the \
browsers http://community.kde.org/Plasma/Plasma_Media_Center/Media_Browser</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f7f2366)</span></li>
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml \
<span style="color: grey">(a66123e)</span></li>
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir \
<span style="color: grey">(3f2f55d)</span></li>
<li>components/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/MediaGridBrowser.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/MediaGridItemDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/MediaItemDelegateLogic.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/MediaLineItemDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/MediaListBrowser.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/TabBrowser.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107861/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic