--===============1954015867873788402== Content-Type: multipart/alternative; boundary="===============8909911342480413678==" --===============8909911342480413678== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107861/#review23907 ----------------------------------------------------------- Ship it! Ship It! components/MediaGridItemDelegate.qml will this not be used? If yes, remove it - Shantanu Tushar On Dec. 23, 2012, 8:33 a.m., Fabian Riethmayer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107861/ > ----------------------------------------------------------- > = > (Updated Dec. 23, 2012, 8:33 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > First reusable qml components for mediabrowsing. > Description of the browsers http://community.kde.org/Plasma/Plasma_Media_= Center/Media_Browser > = > = > Diffs > ----- > = > CMakeLists.txt f7f2366 = > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccom= ponents/MediaBrowser.qml a66123e = > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccom= ponents/qmldir 3f2f55d = > components/CMakeLists.txt PRE-CREATION = > components/MediaGridBrowser.qml PRE-CREATION = > components/MediaGridItemDelegate.qml PRE-CREATION = > components/MediaItemDelegateLogic.js PRE-CREATION = > components/MediaLineItemDelegate.qml PRE-CREATION = > components/MediaListBrowser.qml PRE-CREATION = > components/TabBrowser.qml PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/107861/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Fabian Riethmayer > = > --===============8909911342480413678== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107861/

Ship it!

Ship It!
 
















 =

 =




 
 
  
   
    components/MediaGridItemDelegate.qml
    

     (Diff revision 1)

    
   
  
 

 
  

   

  
 


  
    
    
    240
            /*if (url) {
  

  
    
    
    241
                eventParams.url =3D url
  

  
    
    
    242
            }*/
  

 



will this not be used? If yes, remove it






- Shantanu




On December 23rd, 2012, 8:33 a.m., Fabian Riethmayer wrote:







 
  

Review request for Plasma.
By Fabian Riethmayer.


Updated Dec. 23, 2012, 8:33 a.m.






Descripti=
on 
 
 
  
   First reusable qml components for mediabrowsing.
Description of the browsers http://community.kde.org/Plasma/Plasma_Media_Ce=
nter/Media_Browser
  
 






Diffs=
 


 CMakeLists.txt (f7f2366)

 browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicco=
mponents/MediaBrowser.qml (a66123e)

 browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicco=
mponents/qmldir (3f2f55d)

 components/CMakeLists.txt (PRE-CREATION)

 components/MediaGridBrowser.qml (PRE-CREAT=
ION)

 components/MediaGridItemDelegate.qml (PRE-=
CREATION)

 components/MediaItemDelegateLogic.js (PRE-=
CREATION)

 components/MediaLineItemDelegate.qml (PRE-=
CREATION)

 components/MediaListBrowser.qml (PRE-CREAT=
ION)

 components/TabBrowser.qml (PRE-CREATION)



View Diff

--===============8909911342480413678==-- --===============1954015867873788402== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1954015867873788402==--