This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107861/

Ship it!

Ship It!

components/MediaGridItemDelegate.qml (Diff revision 1)
240
        /*if (url) {
241
            eventParams.url = url
242
        }*/
will this not be used? If yes, remove it

- Shantanu


On December 23rd, 2012, 8:33 a.m., Fabian Riethmayer wrote:

Review request for Plasma.
By Fabian Riethmayer.

Updated Dec. 23, 2012, 8:33 a.m.

Description

First reusable qml components for mediabrowsing.
Description of the browsers http://community.kde.org/Plasma/Plasma_Media_Center/Media_Browser

Diffs

  • CMakeLists.txt (f7f2366)
  • browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml (a66123e)
  • browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir (3f2f55d)
  • components/CMakeLists.txt (PRE-CREATION)
  • components/MediaGridBrowser.qml (PRE-CREATION)
  • components/MediaGridItemDelegate.qml (PRE-CREATION)
  • components/MediaItemDelegateLogic.js (PRE-CREATION)
  • components/MediaLineItemDelegate.qml (PRE-CREATION)
  • components/MediaListBrowser.qml (PRE-CREATION)
  • components/TabBrowser.qml (PRE-CREATION)

View Diff