[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Make Publisher able to remove the packages which have been installed w
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-23 15:34:03
Message-ID: 20121123153403.20980.62914 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 23, 2012, 12:06 a.m., Aaron J. Seigo wrote:
> > why would "Publish" do the exact opposite and uninstall something? shou=
ldn't this be a different function? in which case is it needed / desired to=
even do this from plasmate?
> =
> Antonis Tsiapaliokas wrote:
> Yes, you have right. The "Publish" should only install things..
> So since plasmate is a tool for developers, should we leave plasmate =
without an uninstall feature?
i think for now, yes. we can put this into a future release perhaps, but le=
t's stay focused on getting a 1.0 release out with all existing features in=
good shape. with all the work you guys have put into it recently, it reall=
y is nearly there!
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107425/#review22407
-----------------------------------------------------------
On Nov. 22, 2012, 8:02 p.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107425/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2012, 8:02 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Hello,
> =
> With this patch the publisher is able to remove the packages which have b=
een installed with the cmake method.
> =
> UI changes:
> *add a new entry to the comboBox with name "CMake Remove Installed Packag=
e"
> *When the current comboBox is the "CMake Remove Installed Package", then =
the text of installButton is changed.
> *the text of the installButtons becomes "Remove Package"
> =
> =
> Diffs
> -----
> =
> plasmate/publisher/publisher.h ebb289e =
> plasmate/publisher/publisher.cpp 60d18b9 =
> =
> Diff: http://git.reviewboard.kde.org/r/107425/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107425/">http://git.reviewboard.kde.org/r/107425/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 23rd, 2012, 12:06 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">why would "Publish" do the exact opposite and uninstall \
something? shouldn't this be a different function? in which case is it needed / \
desired to even do this from plasmate?</pre> </blockquote>
<p>On November 23rd, 2012, 9:14 a.m., <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, you have right. The \
"Publish" should only install things.. So since plasmate is a tool for \
developers, should we leave plasmate without an uninstall feature? </pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think for now, yes. we \
can put this into a future release perhaps, but let's stay focused on getting a \
1.0 release out with all existing features in good shape. with all the work you guys \
have put into it recently, it really is nearly there!</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 22nd, 2012, 8:02 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
With this patch the publisher is able to remove the packages which have been \
installed with the cmake method.
UI changes:
*add a new entry to the comboBox with name "CMake Remove Installed Package"
*When the current comboBox is the "CMake Remove Installed Package", then \
the text of installButton is changed.
*the text of the installButtons becomes "Remove Package"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/publisher/publisher.h <span style="color: grey">(ebb289e)</span></li>
<li>plasmate/publisher/publisher.cpp <span style="color: grey">(60d18b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107425/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic