This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107425/

On November 23rd, 2012, 12:06 a.m., Aaron J. Seigo wrote:

why would "Publish" do the exact opposite and uninstall something? shouldn't this be a different function? in which case is it needed / desired to even do this from plasmate?

On November 23rd, 2012, 9:14 a.m., Antonis Tsiapaliokas wrote:

Yes, you have right. The "Publish" should only install things..
So since plasmate is a tool for developers, should we leave plasmate without an uninstall feature? 
i think for now, yes. we can put this into a future release perhaps, but let's stay focused on getting a 1.0 release out with all existing features in good shape. with all the work you guys have put into it recently, it really is nearly there!

- Aaron J.


On November 22nd, 2012, 8:02 p.m., Antonis Tsiapaliokas wrote:

Review request for Plasma.
By Antonis Tsiapaliokas.

Updated Nov. 22, 2012, 8:02 p.m.

Description

Hello,

With this patch the publisher is able to remove the packages which have been installed with the cmake method.

UI changes:
*add a new entry to the comboBox with name "CMake Remove Installed Package"
*When the current comboBox is the "CMake Remove Installed Package", then the text of installButton is changed.
*the text of the installButtons becomes "Remove Package"

Diffs

  • plasmate/publisher/publisher.h (ebb289e)
  • plasmate/publisher/publisher.cpp (60d18b9)

View Diff