[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: hide save and save as actions in every language
From: "Commit Hook" <null () kde ! org>
Date: 2012-11-23 15:15:59
Message-ID: 20121123151559.19270.6314 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107418/#review22431
-----------------------------------------------------------
This review has been submitted with commit 539decf547bf553e547cf1790bc29c18=
49b0fd85 by Giorgos Tsiapaliokas to branch master.
- Commit Hook
On Nov. 22, 2012, 11:59 a.m., Giorgos Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107418/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2012, 11:59 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> If plasmate's ui is in english the "save" and "save us" actions are invis=
ible, but not for the rest of the languages.
> This patch solves the issue.
> =
> =
> Diffs
> -----
> =
> plasmate/editors/text/texteditor.h 6fb362c =
> plasmate/editors/text/texteditor.cpp 14bccf6 =
> plasmate/mainwindow.cpp 87d6fe3 =
> =
> Diff: http://git.reviewboard.kde.org/r/107418/diff/
> =
> =
> Testing
> -------
> =
> it works, see the image
> =
> =
> Screenshots
> -----------
> =
> =
> http://git.reviewboard.kde.org/r/107418/s/849/
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107418/">http://git.reviewboard.kde.org/r/107418/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 539decf547bf553e547cf1790bc29c1849b0fd85 by Giorgos \
Tsiapaliokas to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 22nd, 2012, 11:59 a.m., Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 11:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If plasmate's ui is in english the "save" and "save \
us" actions are invisible, but not for the rest of the languages. This patch \
solves the issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it works, see the image</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/editors/text/texteditor.h <span style="color: \
grey">(6fb362c)</span></li>
<li>plasmate/editors/text/texteditor.cpp <span style="color: \
grey">(14bccf6)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(87d6fe3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107418/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107418/s/849/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/22/plasmate-de-no-save_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic