[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: add preview thumbnail at color wallpaper config dialog
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-09-29 14:02:25
Message-ID: 20120929140225.2985.9150 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/#review19580
-----------------------------------------------------------
plasma/generic/wallpapers/color/color.h
<http://git.reviewboard.kde.org/r/106626/#comment15571>
Hello,
=
I know that this is not part of your patch. But could you remove this w=
hitespace with your patch?
- Antonis Tsiapaliokas
On Sept. 28, 2012, 11:56 p.m., Reza Shah wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106626/
> -----------------------------------------------------------
> =
> (Updated Sept. 28, 2012, 11:56 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This is part of my feature plan for 4.10.
> =
> Added preview thumbnail at color wallpaper configuration dialog for each =
background mode, =
> and removed the background mode combobox. =
> =
> =
> Diffs
> -----
> =
> plasma/generic/wallpapers/color/CMakeLists.txt 71006ee =
> plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 =
> plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 =
> plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 =
> plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 =
> plasma/generic/wallpapers/color/color.h a477aa9 =
> plasma/generic/wallpapers/color/color.cpp d696c2d =
> plasma/generic/wallpapers/color/config.ui d5bf809 =
> plasma/generic/wallpapers/color/itemsview.h e69de29 =
> plasma/generic/wallpapers/color/itemsview.cpp e69de29 =
> =
> Diff: http://git.reviewboard.kde.org/r/106626/diff/
> =
> =
> Testing
> -------
> =
> tested against master, worked fine.
> =
> =
> Screenshots
> -----------
> =
> new config dialog
> http://git.reviewboard.kde.org/r/106626/s/740/
> =
> =
> Thanks,
> =
> Reza Shah
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106626/">http://git.reviewboard.kde.org/r/106626/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106626/diff/1/?file=87655#file87655line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/wallpapers/color/color.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">virtual</span> <span class="kt">void</span> <span \
class="n">init</span><span class="p">(</span><span class="k">const</span> <span \
class="n">KConfigGroup</span> <span class="o">&</span><span \
class="n">config</span><span class="p">);</span><span class="ew"> \
</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "> <span class="k">virtual</span> <span class="kt">void</span> <span \
class="n">init</span><span class="p">(</span><span class="k">const</span> <span \
class="n">KConfigGroup</span> <span class="o">&</span><span \
class="n">config</span><span class="p">);</span><span class="ew"> \
</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,
I know that this is not part of your patch. But could you remove this whitespace with \
your patch?</pre> </div>
<br />
<p>- Antonis</p>
<br />
<p>On September 28th, 2012, 11:56 p.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2012, 11:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is part of my feature plan for 4.10.
Added preview thumbnail at color wallpaper configuration dialog for each background \
mode, and removed the background mode combobox. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master, worked fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/wallpapers/color/CMakeLists.txt <span style="color: \
grey">(71006ee)</span></li>
<li>plasma/generic/wallpapers/color/backgrounddelegate.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgrounddelegate.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgroundlistmodel.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgroundlistmodel.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/color.h <span style="color: \
grey">(a477aa9)</span></li>
<li>plasma/generic/wallpapers/color/color.cpp <span style="color: \
grey">(d696c2d)</span></li>
<li>plasma/generic/wallpapers/color/config.ui <span style="color: \
grey">(d5bf809)</span></li>
<li>plasma/generic/wallpapers/color/itemsview.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/itemsview.cpp <span style="color: \
grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106626/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106626/s/740/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/colorlistview_400x100.png" \
style="border: 1px black solid;" alt="new config dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic