--===============5606393668917368882== Content-Type: multipart/alternative; boundary="===============3722504557417322977==" --===============3722504557417322977== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/#review19580 ----------------------------------------------------------- plasma/generic/wallpapers/color/color.h Hello, = I know that this is not part of your patch. But could you remove this w= hitespace with your patch? - Antonis Tsiapaliokas On Sept. 28, 2012, 11:56 p.m., Reza Shah wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106626/ > ----------------------------------------------------------- > = > (Updated Sept. 28, 2012, 11:56 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This is part of my feature plan for 4.10. > = > Added preview thumbnail at color wallpaper configuration dialog for each = background mode, = > and removed the background mode combobox. = > = > = > Diffs > ----- > = > plasma/generic/wallpapers/color/CMakeLists.txt 71006ee = > plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 = > plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 = > plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 = > plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 = > plasma/generic/wallpapers/color/color.h a477aa9 = > plasma/generic/wallpapers/color/color.cpp d696c2d = > plasma/generic/wallpapers/color/config.ui d5bf809 = > plasma/generic/wallpapers/color/itemsview.h e69de29 = > plasma/generic/wallpapers/color/itemsview.cpp e69de29 = > = > Diff: http://git.reviewboard.kde.org/r/106626/diff/ > = > = > Testing > ------- > = > tested against master, worked fine. > = > = > Screenshots > ----------- > = > new config dialog > http://git.reviewboard.kde.org/r/106626/s/740/ > = > = > Thanks, > = > Reza Shah > = > --===============3722504557417322977== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106626/

= =

plasma/generic/wallpapers/color/color.h (Diff revision 1)

41	virtual void init(<= /span>const KConfigGroup = &config);	44	virtual void init(<= /span>const KConfigGroup = &config);

Hello,

I know that this is not part of your patch. But could you remove this white=
space with your patch?

- Antonis

On September 28th, 2012, 11:56 p.m., Reza Shah wrote:

Review request for Plasma.

By Reza Shah.

Updated Sept. 28, 2012, 11:56 p.m.

Descripti= on

This is part of my feature plan for 4.10.

Added preview thumbnail at color wallpaper configuration dialog for each ba=
ckground mode, =

and removed the background mode combobox.

Testing <= /h1>

tested against master, worked fine.

Diffs=

plasma/generic/wallpapers/color/CMakeLists.txt (71006ee)
plasma/generic/wallpapers/color/backgrounddelegate.h (e69de29)
plasma/generic/wallpapers/color/backgrounddelegate.cpp (e69de29)
plasma/generic/wallpapers/color/backgroundlistmodel.h (e69de29)
plasma/generic/wallpapers/color/backgroundlistmodel.cpp (e69de29)
plasma/generic/wallpapers/color/color.h (a= 477aa9)
plasma/generic/wallpapers/color/color.cpp = (d696c2d)
plasma/generic/wallpapers/color/config.ui = (d5bf809)
plasma/generic/wallpapers/color/itemsview.h (e69de29)

Screensho= ts

3D"new

--===============3722504557417322977==-- --===============5606393668917368882== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5606393668917368882==--