'Re: Review Request: add preview thumbnail at color wallpaper config dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: add preview thumbnail at color wallpaper config dialog
From:       "Reza Shah" <rshah0385 () kireihana ! com>
Date:       2012-10-02 11:48:17
Message-ID: 20121002114817.18365.44095 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/
-----------------------------------------------------------

(Updated Oct. 2, 2012, 11:48 a.m.)

Review request for Plasma and Marco Martin.

Changes
-------

- removed trailing spaces from init() inside color.h =

- added copyright line to color.h

Description
-------

This is part of my feature plan for 4.10.

Added preview thumbnail at color wallpaper configuration dialog for each ba=
ckground mode, =

and removed the background mode combobox. =

Diffs (updated)
-----

  plasma/generic/wallpapers/color/CMakeLists.txt 71006ee =

  plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 =

  plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 =

  plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 =

  plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 =

  plasma/generic/wallpapers/color/color.h a477aa9 =

  plasma/generic/wallpapers/color/color.cpp d696c2d =

  plasma/generic/wallpapers/color/config.ui d5bf809 =

  plasma/generic/wallpapers/color/itemsview.h e69de29 =

  plasma/generic/wallpapers/color/itemsview.cpp e69de29 =

Diff: http://git.reviewboard.kde.org/r/106626/diff/

Testing
-------

tested against master, worked fine.

Screenshots
-----------

new config dialog
  http://git.reviewboard.kde.org/r/106626/s/740/

Thanks,

Reza Shah

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106626/">http://git.reviewboard.kde.org/r/106626/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated Oct. 2, 2012, 11:48 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- removed trailing spaces from init() inside color.h 
- added copyright line to color.h</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is part of my feature plan for 4.10.

Added preview thumbnail at color wallpaper configuration dialog for each background \
mode,  and removed the background mode combobox. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master, worked fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/wallpapers/color/CMakeLists.txt <span style="color: \
grey">(71006ee)</span></li>

 <li>plasma/generic/wallpapers/color/backgrounddelegate.h <span style="color: \
grey">(e69de29)</span></li>

 <li>plasma/generic/wallpapers/color/backgrounddelegate.cpp <span style="color: \
grey">(e69de29)</span></li>

 <li>plasma/generic/wallpapers/color/backgroundlistmodel.h <span style="color: \
grey">(e69de29)</span></li>

 <li>plasma/generic/wallpapers/color/backgroundlistmodel.cpp <span style="color: \
grey">(e69de29)</span></li>

 <li>plasma/generic/wallpapers/color/color.h <span style="color: \
grey">(a477aa9)</span></li>

 <li>plasma/generic/wallpapers/color/color.cpp <span style="color: \
grey">(d696c2d)</span></li>

 <li>plasma/generic/wallpapers/color/config.ui <span style="color: \
grey">(d5bf809)</span></li>

 <li>plasma/generic/wallpapers/color/itemsview.h <span style="color: \
grey">(e69de29)</span></li>

 <li>plasma/generic/wallpapers/color/itemsview.cpp <span style="color: \
grey">(e69de29)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106626/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106626/s/740/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/colorlistview_400x100.png" \
style="border: 1px black solid;" alt="new config dialog" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 