[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-09-29 13:56:50
Message-ID: 20120929135650.1784.15314 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106622/#review19578
-----------------------------------------------------------
applets/microblog/microblog.cpp
<http://git.reviewboard.kde.org/r/106622/#comment15567>
There is a small coding style error. The "*" should be next to failureWidget and \
not in the middle.
- Antonis Tsiapaliokas
On Sept. 28, 2012, 12:57 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106622/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 12:57 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Calling setFailedToLaunch removes all child items which causes lots of trouble down \
> the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706
>
> Diffs
> -----
>
> applets/microblog/microblog.cpp 376a3cd
>
> Diff: http://git.reviewboard.kde.org/r/106622/diff/
>
>
> Testing
> -------
>
> Assuming you have a microblog plasmoid
>
> 1. Either remove microblogging library or change the name of the engine in the code
> 2. Restart plasma-desktop
>
> Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, \
> the plasmoid loads without functionallity and with a label saying it failed to load \
> the engine.
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106622/">http://git.reviewboard.kde.org/r/106622/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106622/diff/1/?file=87534#file87534line269" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/microblog/microblog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QGraphicsWidget *MicroBlog::graphicsWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">261</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QGraphicsWidget</span> <span class="o">*</span> <span \
class="n">failureWidget</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">QGraphicsWidget</span><span class="p">(</span><span \
class="k">this</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a \
small coding style error. The "*" should be next to failureWidget and not \
in the middle.</pre> </div>
<br />
<p>- Antonis</p>
<br />
<p>On September 28th, 2012, 12:57 p.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2012, 12:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Calling setFailedToLaunch removes all child items which causes lots of \
trouble down the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Assuming you have a microblog plasmoid
1. Either remove microblogging library or change the name of the engine in the code
2. Restart plasma-desktop
Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, \
the plasmoid loads without functionallity and with a label saying it failed to load \
the engine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/microblog/microblog.cpp <span style="color: grey">(376a3cd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106622/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic