This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/

applets/microblog/microblog.cpp (Diff revision 1) 
QGraphicsWidget *MicroBlog::graphicsWidget()
 

    261
    
        QGraphicsWidget * failureWidget = new QGraphicsWidget(this);

  


 





There is a small coding style error. The "*" should be next to failureWidget and not in the middle.









- Antonis






On September 28th, 2012, 12:57 p.m., David Narváez wrote:









 

  


Review request for Plasma.


By David Narváez.




Updated Sept. 28, 2012, 12:57 p.m.








Description 

 

 

  
   
Calling setFailedToLaunch removes all child items which causes lots of trouble down the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706

  		
 






Testing 



 

  
   
Assuming you have a microblog plasmoid

1. Either remove microblogging library or change the name of the engine in the code
2. Restart plasma-desktop

Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, the plasmoid loads without functionallity and with a label saying it failed to load the engine.

  		
 








Diffs 


    

 
  • applets/microblog/microblog.cpp (376a3cd)
    • 





View Diff