'Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2012-10-10 13:24:08
Message-ID: 20121010132408.25368.29886 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106622/
-----------------------------------------------------------

(Updated Oct. 10, 2012, 1:24 p.m.)

Review request for Plasma.

Changes
-------

Fixed * mark

Description
-------

Calling setFailedToLaunch removes all child items which causes lots of trouble down \
the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706

Diffs (updated)
-----

  applets/microblog/microblog.cpp 376a3cd 

Diff: http://git.reviewboard.kde.org/r/106622/diff/

Testing
-------

Assuming you have a microblog plasmoid

1. Either remove microblogging library or change the name of the engine in the code
2. Restart plasma-desktop

Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, \
the plasmoid loads without functionallity and with a label saying it failed to load \
the engine.

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106622/">http://git.reviewboard.kde.org/r/106622/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Oct. 10, 2012, 1:24 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed * mark</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Calling setFailedToLaunch removes all child items which causes lots of \
trouble down the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Assuming you have a microblog plasmoid

1. Either remove microblogging library or change the name of the engine in the code
2. Restart plasma-desktop

Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, \
the plasmoid loads without functionallity and with a label saying it failed to load \
the engine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/microblog/microblog.cpp <span style="color: grey">(376a3cd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106622/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 