'Re: Review Request: Fixes for PlasmaCore.SortFilterModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fixes for PlasmaCore.SortFilterModel
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-28 16:16:13
Message-ID: 20120828161613.17224.55573 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106248/#review18168
-----------------------------------------------------------

This review has been submitted with commit 51f9e2caeb2b1c8253062eaa29130dc6=
110f0aad by Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit Hook

On Aug. 28, 2012, 3:56 p.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106248/
> -----------------------------------------------------------
> =

> (Updated Aug. 28, 2012, 3:56 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> This patch fixes a few tiny problems with PlasmaCore.SortFilterModel:
> =

> - it adds notify signals to filterRegExp and model properties
> - it allows setting source model of SortFilterModel to 0
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/core/tests/CMakeLists.txt PRE-CREATION =

>   plasma/declarativeimports/core/tests/sortfiltermodeltest.h PRE-CREATION =

>   plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp PRE-CREATI=
ON =

>   plasma/declarativeimports/core/CMakeLists.txt 49f2914 =

>   plasma/declarativeimports/core/datamodel.h cf82648 =

>   plasma/declarativeimports/core/datamodel.cpp 00108b1 =

> =

> Diff: http://git.reviewboard.kde.org/r/106248/diff/
> =

> =

> Testing
> -------
> =

> Patch comes with unittests for the changes. I also tested it with KDE Hom=
erun (we have a copy of the class in the code because it needs to work with=
 KDE 4.8 for now).
> =

> =

> Thanks,
> =

> Aur=C3=A9lien G=C3=A2teau
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106248/">http://git.reviewboard.kde.org/r/106248/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 51f9e2caeb2b1c8253062eaa29130dc6110f0aad by Aurélien Gâteau \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 28th, 2012, 3:56 p.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2012, 3:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a few tiny problems with PlasmaCore.SortFilterModel:

- it adds notify signals to filterRegExp and model properties
- it allows setting source model of SortFilterModel to 0</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch comes with unittests for the changes. I also tested it with KDE \
Homerun (we have a copy of the class in the code because it needs to work with KDE \
4.8 for now).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/core/tests/sortfiltermodeltest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(49f2914)</span></li>

 <li>plasma/declarativeimports/core/datamodel.h <span style="color: \
grey">(cf82648)</span></li>

 <li>plasma/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(00108b1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106248/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 