[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: LCD Weather Station QML port
From: "Luis Gabriel Lima" <lampih () gmail ! com>
Date: 2012-08-29 0:22:36
Message-ID: 20120829002236.31382.46678 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106226/#review18201
-----------------------------------------------------------
applets/weatherstation/package/contents/ui/LCDDisplay.qml
<http://git.reviewboard.kde.org/r/106226/#comment14402>
I still think we should keep as it is now to make the text color consis=
tent with the lcd display color. Even if the theme changes, the lcd display=
will stay with the same color because it's an image.
- Luis Gabriel Lima
On Aug. 27, 2012, 3:52 p.m., Luis Gabriel Lima wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106226/
> -----------------------------------------------------------
> =
> (Updated Aug. 27, 2012, 3:52 p.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> This patch is part of the work done in my GSoC 2012 project and contains =
the new version of the LCD Weather Station plasmoid.
> =
> =
> Diffs
> -----
> =
> applets/weatherstation/CMakeLists.txt 748de4a =
> applets/weatherstation/lcd.svgz 7f5f3d3 =
> applets/weatherstation/lcd2.svgz PRE-CREATION =
> applets/weatherstation/lcd_digits.svgz PRE-CREATION =
> applets/weatherstation/package/contents/ui/LCDDigit.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/LCDDisplay.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/Wind.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/main.qml PRE-CREATION =
> applets/weatherstation/package/metadata.desktop PRE-CREATION =
> applets/weatherstation/weather_icons.svgz PRE-CREATION =
> applets/weatherstation/weatherstation.h 6d4ae24 =
> applets/weatherstation/weatherstation.cpp 8ada9c2 =
> applets/weatherstation/wind_arrows.svgz PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106226/diff/
> =
> =
> Testing
> -------
> =
> - Tested inside panels and floating on desktop
> - Tested with various providers and locations
> =
> =
> Screenshots
> -----------
> =
> LCD background
> http://git.reviewboard.kde.org/r/106226/s/701/
> No background
> http://git.reviewboard.kde.org/r/106226/s/702/
> =
> =
> Thanks,
> =
> Luis Gabriel Lima
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106226/">http://git.reviewboard.kde.org/r/106226/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106226/diff/1/?file=81359#file81359line74" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weatherstation/package/contents/ui/LCDDisplay.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">74</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
color: "#202020"</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still \
think we should keep as it is now to make the text color consistent with the lcd \
display color. Even if the theme changes, the lcd display will stay with the same \
color because it's an image.</pre> </div>
<br />
<p>- Luis Gabriel</p>
<br />
<p>On August 27th, 2012, 3:52 p.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is part of the work done in my GSoC 2012 project and contains \
the new version of the LCD Weather Station plasmoid.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Tested inside panels and floating on desktop
- Tested with various providers and locations</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/weatherstation/CMakeLists.txt <span style="color: \
grey">(748de4a)</span></li>
<li>applets/weatherstation/lcd.svgz <span style="color: grey">(7f5f3d3)</span></li>
<li>applets/weatherstation/lcd2.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/lcd_digits.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/LCDDigit.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/LCDDisplay.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/Wind.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/weather_icons.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/weatherstation.h <span style="color: \
grey">(6d4ae24)</span></li>
<li>applets/weatherstation/weatherstation.cpp <span style="color: \
grey">(8ada9c2)</span></li>
<li>applets/weatherstation/wind_arrows.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106226/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106226/s/701/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weatherstation1_400x100.png" \
style="border: 1px black solid;" alt="LCD background" /></a>
<a href="http://git.reviewboard.kde.org/r/106226/s/702/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weatherstation2_400x100.png" \
style="border: 1px black solid;" alt="No background" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic