From kde-panel-devel Tue Aug 28 16:16:13 2012 From: "Commit Hook" Date: Tue, 28 Aug 2012 16:16:13 +0000 To: kde-panel-devel Subject: Re: Review Request: Fixes for PlasmaCore.SortFilterModel Message-Id: <20120828161613.17224.55573 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134617059810201 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1539635907410458924==" --===============1539635907410458924== Content-Type: multipart/alternative; boundary="===============7820165119422447753==" --===============7820165119422447753== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106248/#review18168 ----------------------------------------------------------- This review has been submitted with commit 51f9e2caeb2b1c8253062eaa29130dc6= 110f0aad by Aur=C3=A9lien G=C3=A2teau to branch master. - Commit Hook On Aug. 28, 2012, 3:56 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106248/ > ----------------------------------------------------------- > = > (Updated Aug. 28, 2012, 3:56 p.m.) > = > = > Review request for Plasma and Marco Martin. > = > = > Description > ------- > = > This patch fixes a few tiny problems with PlasmaCore.SortFilterModel: > = > - it adds notify signals to filterRegExp and model properties > - it allows setting source model of SortFilterModel to 0 > = > = > Diffs > ----- > = > plasma/declarativeimports/core/tests/CMakeLists.txt PRE-CREATION = > plasma/declarativeimports/core/tests/sortfiltermodeltest.h PRE-CREATION = > plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp PRE-CREATI= ON = > plasma/declarativeimports/core/CMakeLists.txt 49f2914 = > plasma/declarativeimports/core/datamodel.h cf82648 = > plasma/declarativeimports/core/datamodel.cpp 00108b1 = > = > Diff: http://git.reviewboard.kde.org/r/106248/diff/ > = > = > Testing > ------- > = > Patch comes with unittests for the changes. I also tested it with KDE Hom= erun (we have a copy of the class in the code because it needs to work with= KDE 4.8 for now). > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============7820165119422447753== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106248/ 

This revie=
w has been submitted with commit 51f9e2caeb2b1c8253062eaa29130dc6110f0aad b=
y Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit


On August 28th, 2012, 3:56 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma and Marco Martin.
By Aur=C3=A9lien G=C3=A2teau.

Updated Aug. 28, 2012, 3:56 p.m.

Descripti= on 

This patch fixes a few tiny problems with PlasmaCore.SortFil=
terModel:

- it adds notify signals to filterRegExp and model properties
- it allows setting source model of SortFilterModel to 0

Testing <= /h1> 
Patch comes with unittests for the changes. I also tested it=
 with KDE Homerun (we have a copy of the class in the code because it needs=
 to work with KDE 4.8 for now).

Diffs=

  • plasma/declarativeimports/core/tests/CMakeLists.txt (PRE-CREATION)
  • plasma/declarativeimports/core/tests/sortfiltermodeltest.h (PRE-CREATION)
  • plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp (PRE-CREATION)
  • plasma/declarativeimports/core/CMakeLists.txt (49f2914)
  • plasma/declarativeimports/core/datamodel.h (cf82648)
  • plasma/declarativeimports/core/datamodel.cpp (00108b1)

View Diff
--===============7820165119422447753==-- --===============1539635907410458924== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1539635907410458924==--