'Review Request: Do not disable the "Delete" action after deleting one item'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Do not disable the "Delete" action after deleting one item
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2012-07-29 4:35:15
Message-ID: 20120729043515.21070.75981 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105778/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

I fail to figure out from the existing code the intention of disabling the "Delete" \
action after deleting one item. Maybe for the edge case of the last item being \
deleted? But the patched code works well in that edge case, too.

The git history does not provide much hint. Those lines of disabling those actions \
were written and last updated almost ten year ago.

This addresses bug 296682.
    http://bugs.kde.org/show_bug.cgi?id=296682

Diffs
-----

  kmenuedit/treeview.cpp d0e6553 

Diff: http://git.reviewboard.kde.org/r/105778/diff/

Testing
-------

I haven't noticed any problem after applying this patch.

Thanks,

Jekyll Wu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105778/">http://git.reviewboard.kde.org/r/105778/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I fail to figure out from the existing code the intention of disabling \
the &quot;Delete&quot; action after deleting one item. Maybe for the edge case of the \
last item being deleted? But the patched code works well in that edge case, too.

The git history does not provide much hint. Those lines of disabling those actions \
were written and last updated almost ten year ago. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I haven&#39;t noticed any problem after applying this patch. </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=296682">296682</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmenuedit/treeview.cpp <span style="color: grey">(d0e6553)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105778/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 