From kde-panel-devel Sun Jul 29 04:35:15 2012 From: "Jekyll Wu" Date: Sun, 29 Jul 2012 04:35:15 +0000 To: kde-panel-devel Subject: Review Request: Do not disable the "Delete" action after deleting one item Message-Id: <20120729043515.21070.75981 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134353680431070 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8569867708929795800==" --===============8569867708929795800== Content-Type: multipart/alternative; boundary="===============6238539051149345262==" --===============6238539051149345262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105778/ ----------------------------------------------------------- Review request for Plasma. Description ------- I fail to figure out from the existing code the intention of disabling the = "Delete" action after deleting one item. Maybe for the edge case of the las= t item being deleted? But the patched code works well in that edge case, to= o. The git history does not provide much hint. Those lines of disabling those = actions were written and last updated almost ten year ago. This addresses bug 296682. http://bugs.kde.org/show_bug.cgi?id=3D296682 Diffs ----- kmenuedit/treeview.cpp d0e6553 = Diff: http://git.reviewboard.kde.org/r/105778/diff/ Testing ------- I haven't noticed any problem after applying this patch. Thanks, Jekyll Wu --===============6238539051149345262== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105778/

Review request for Plasma.
By Jekyll Wu.

Descripti= on 

I fail to figure out from the existing code the intention of=
 disabling the "Delete" action after deleting one item. Maybe for=
 the edge case of the last item being deleted? But the patched code works w=
ell in that edge case, too.

The git history does not provide much hint. Those lines of disabling those =
actions were written and last updated almost ten year ago.

Testing <= /h1> 
I haven't noticed any problem after applying this patch.
Bugs: 296682

Diffs=

  • kmenuedit/treeview.cpp (d0e6553)

View Diff
--===============6238539051149345262==-- --===============8569867708929795800== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8569867708929795800==--