[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: change default config of taskmanager
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-07-26 14:47:52
Message-ID: 20120726144752.21113.88157 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review16487
-----------------------------------------------------------
Was this change intended for 4.9 or just master as indicated in this request? Branch \
is actually in freeze, the bug fix says "Fixed in 4.9.1", but the change will be in \
4.9.0 unless it is reverted in branch.
Additionally, I thought plasma uses kdelibs coding style. If that's the case, there \
need to be braces even in single-statement if/else.
- Christoph Feck
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ") entrys, \
> so I moved them to the Items list. I don't know why they were separated in the \
> first place. That's why I'm opening this review request.
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -----
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> -------
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105374/">http://git.reviewboard.kde.org/r/105374/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Was this change intended \
for 4.9 or just master as indicated in this request? Branch is actually in freeze, \
the bug fix says "Fixed in 4.9.1", but the change will be in 4.9.0 unless \
it is reverted in branch.
Additionally, I thought plasma uses kdelibs coding style. If that's the case, \
there need to be braces even in single-statement if/else.</pre> <br />
<p>- Christoph</p>
<br />
<p>On June 28th, 2012, 7:03 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated June 28, 2012, 7:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">libtaskmanager can't remove those ("browser", \
"preferred://browser, , , ") entrys, so I moved them to the Items list. I \
don't know why they were separated in the first place. That's why I'm \
opening this review request.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">no regressions noted.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278724">278724</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(5ca0159)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105374/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic