This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/

Was this change intended for 4.9 or just master as indicated in this request? Branch is actually in freeze, the bug fix says "Fixed in 4.9.1", but the change will be in 4.9.0 unless it is reverted in branch.

Additionally, I thought plasma uses kdelibs coding style. If that's the case, there need to be braces even in single-statement if/else.

- Christoph


On June 28th, 2012, 7:03 p.m., Greg T wrote:

Review request for Plasma.
By Greg T.

Updated June 28, 2012, 7:03 p.m.

Description

libtaskmanager can't remove those ("browser", "preferred://browser, , , ") entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request.

Testing

no regressions noted.
Bugs: 278724

Diffs

  • libs/taskmanager/groupmanager.cpp (5ca0159)

View Diff