From kde-panel-devel Thu Jul 26 14:47:52 2012 From: "Christoph Feck" Date: Thu, 26 Jul 2012 14:47:52 +0000 To: kde-panel-devel Subject: Re: Review Request: change default config of taskmanager Message-Id: <20120726144752.21113.88157 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134331434630501 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6157425319300087909==" --===============6157425319300087909== Content-Type: multipart/alternative; boundary="===============4586161945184910566==" --===============4586161945184910566== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/#review16487 ----------------------------------------------------------- Was this change intended for 4.9 or just master as indicated in this reques= t? Branch is actually in freeze, the bug fix says "Fixed in 4.9.1", but the= change will be in 4.9.0 unless it is reverted in branch. Additionally, I thought plasma uses kdelibs coding style. If that's the cas= e, there need to be braces even in single-statement if/else. - Christoph Feck On June 28, 2012, 7:03 p.m., Greg T wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105374/ > ----------------------------------------------------------- > = > (Updated June 28, 2012, 7:03 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > libtaskmanager can't remove those ("browser", "preferred://browser, , , "= ) entrys, so I moved them to the Items list. I don't know why they were sep= arated in the first place. That's why I'm opening this review request. > = > = > This addresses bug 278724. > http://bugs.kde.org/show_bug.cgi?id=3D278724 > = > = > Diffs > ----- > = > libs/taskmanager/groupmanager.cpp 5ca0159 = > = > Diff: http://git.reviewboard.kde.org/r/105374/diff/ > = > = > Testing > ------- > = > no regressions noted. > = > = > Thanks, > = > Greg T > = > --===============4586161945184910566== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105374/ 

Was this c=
hange intended for 4.9 or just master as indicated in this request? Branch =
is actually in freeze, the bug fix says "Fixed in 4.9.1", but the=
 change will be in 4.9.0 unless it is reverted in branch.

Additionally, I thought plasma uses kdelibs coding style. If that's the=
 case, there need to be braces even in single-statement if/else.

- Christoph


On June 28th, 2012, 7:03 p.m., Greg T wrote:

Review request for Plasma.
By Greg T.

Updated June 28, 2012, 7:03 p.m.

Descripti= on 

libtaskmanager can't remove those ("browser", =
"preferred://browser, , , ") entrys, so I moved them to the Items=
 list. I don't know why they were separated in the first place. That=
9;s why I'm opening this review request.

Testing <= /h1> 
no regressions noted.
Bugs: 278724

Diffs=

  • libs/taskmanager/groupmanager.cpp (5ca0159= )

View Diff
--===============4586161945184910566==-- --===============6157425319300087909== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6157425319300087909==--