[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix the minimum size of some applets
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-07-26 10:31:15
Message-ID: 20120726103115.7981.38458 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote:
> > applets/pastebin/pastebin.cpp, line 263
> > <http://git.reviewboard.kde.org/r/105234/diff/4/?file=67585#file67585line263>
> >
> > why 33?
>
> Maarten De Meyer wrote:
> As I explained to David:
> "If it is 32 the iconSize() method (as I understand it) selects a smaller icon.
> iconSize() returns the biggest fitting icon, if the rectangle is 32x32 the biggest \
> fitting icon is 16x16. This looks way too small on the desktop and is not \
> consistent with other applets. If the rectangle is 1 pixel higher and wider it \
> works and looks better."
> However it still seems to select a smaller icon now anyway so I changed it.
instead of 32 and 33 you may use KIconLoader::SizeMedium (that is usually 32, but \
cleaner)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review14728
-----------------------------------------------------------
On June 29, 2012, 11:13 a.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 11:13 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This fixes the minimum size of the following applets: showdashboard, \
> systemloadviewer, pastebin, weatherstation and timer. Some sizes were to small, so \
> there were visual glitches and some applets had no minimum value set.
> I have no commit rights.
>
>
> Diffs
> -----
>
> applets/pastebin/pastebin.cpp 208e6a3
> applets/showdashboard/showdashboard.h 695347f
> applets/showdashboard/showdashboard.cpp 1c2f623
> applets/systemloadviewer/systemloadviewer.cpp b852256
> applets/timer/timer.cpp ba5ee66
> applets/weatherstation/weatherstation.h 6d4ae24
> applets/weatherstation/weatherstation.cpp 8ada9c2
>
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
>
>
> Testing
> -------
>
> Run the applets with their new minimum size, and minimized.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105234/">http://git.reviewboard.kde.org/r/105234/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 14th, 2012, 10:33 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105234/diff/4/?file=67585#file67585line263" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/pastebin/pastebin.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Pastebin::constraintsEvent(Plasma::Constraints constraints)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">263</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span> <span class="n">setMinimumSize</span><span \
class="p">(</span><span class="mi">33</span><span class="p">,</span> <span \
class="mi">33</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why 33?</pre> \
</blockquote>
<p>On June 22nd, 2012, 6:17 a.m., <b>Maarten De Meyer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I explained to David: \
"If it is 32 the iconSize() method (as I understand it) selects a smaller icon. \
iconSize() returns the biggest fitting icon, if the rectangle is 32x32 the biggest \
fitting icon is 16x16. This looks way too small on the desktop and is not consistent \
with other applets. If the rectangle is 1 pixel higher and wider it works and looks \
better."
However it still seems to select a smaller icon now anyway so I changed it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of \
32 and 33 you may use KIconLoader::SizeMedium (that is usually 32, but cleaner)</pre> \
<br />
<p>- Marco</p>
<br />
<p>On June 29th, 2012, 11:13 a.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated June 29, 2012, 11:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the minimum size of the following applets: showdashboard, \
systemloadviewer, pastebin, weatherstation and timer. Some sizes were to small, so \
there were visual glitches and some applets had no minimum value set.
I have no commit rights.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run the applets with their new minimum size, and minimized.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/pastebin/pastebin.cpp <span style="color: grey">(208e6a3)</span></li>
<li>applets/showdashboard/showdashboard.h <span style="color: \
grey">(695347f)</span></li>
<li>applets/showdashboard/showdashboard.cpp <span style="color: \
grey">(1c2f623)</span></li>
<li>applets/systemloadviewer/systemloadviewer.cpp <span style="color: \
grey">(b852256)</span></li>
<li>applets/timer/timer.cpp <span style="color: grey">(ba5ee66)</span></li>
<li>applets/weatherstation/weatherstation.h <span style="color: \
grey">(6d4ae24)</span></li>
<li>applets/weatherstation/weatherstation.cpp <span style="color: \
grey">(8ada9c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105234/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic