From kde-panel-devel Thu Jul 26 10:31:15 2012 From: "Marco Martin" Date: Thu, 26 Jul 2012 10:31:15 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix the minimum size of some applets Message-Id: <20120726103115.7981.38458 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134329895024117 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3089009890681864259==" --===============3089009890681864259== Content-Type: multipart/alternative; boundary="===============7059925289882681173==" --===============7059925289882681173== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote: > > applets/pastebin/pastebin.cpp, line 263 > > > > > > why 33? > = > Maarten De Meyer wrote: > As I explained to David: > "If it is 32 the iconSize() method (as I understand it) selects a sma= ller icon. > iconSize() returns the biggest fitting icon, if the rectangle is 32x3= 2 the biggest fitting icon is 16x16. This looks way too small on the deskto= p and is not consistent with other applets. > If the rectangle is 1 pixel higher and wider it works and looks bette= r." > = > However it still seems to select a smaller icon now anyway so I chang= ed it. instead of 32 and 33 you may use KIconLoader::SizeMedium (that is usually 3= 2, but cleaner) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14728 ----------------------------------------------------------- On June 29, 2012, 11:13 a.m., Maarten De Meyer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105234/ > ----------------------------------------------------------- > = > (Updated June 29, 2012, 11:13 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This fixes the minimum size of the following applets: showdashboard, syst= emloadviewer, pastebin, weatherstation and timer. > Some sizes were to small, so there were visual glitches and some applets = had no minimum value set. > = > I have no commit rights. > = > = > Diffs > ----- > = > applets/pastebin/pastebin.cpp 208e6a3 = > applets/showdashboard/showdashboard.h 695347f = > applets/showdashboard/showdashboard.cpp 1c2f623 = > applets/systemloadviewer/systemloadviewer.cpp b852256 = > applets/timer/timer.cpp ba5ee66 = > applets/weatherstation/weatherstation.h 6d4ae24 = > applets/weatherstation/weatherstation.cpp 8ada9c2 = > = > Diff: http://git.reviewboard.kde.org/r/105234/diff/ > = > = > Testing > ------- > = > Run the applets with their new minimum size, and minimized. > = > = > Thanks, > = > Maarten De Meyer > = > --===============7059925289882681173== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105234/

On June 14th, 2012, 10:33 a.m., Aaron J. Se= igo wrote:

= = =
applets/pastebin/pastebin.cpp (Diff revision 4)
void Pastebin::constraintsEvent(Plasma::Constraints constraints)
263
	    setMinimumSize(33, 33);
why 33?
 

On June 22nd, 2012, 6:17 a.m., Maarten De Meyer wrote:

As I expl=
ained to David:
"If it is 32 the iconSize() method (as I understand it) selects a smal=
ler icon.
iconSize() returns the biggest fitting icon, if the rectangle is 32x32 the =
biggest fitting icon is 16x16. This looks way too small on the desktop and =
is not consistent with other applets.
If the rectangle is 1 pixel higher and wider it works and looks better.&quo=
t;

However it still seems to select a smaller icon now anyway so I changed it.=

instead of 32 and 33 you may use KIconLoader::SizeMedium (that is us=
ually 32, but cleaner)

- Marco

On June 29th, 2012, 11:13 a.m., Maarten De Meyer wrote:

Review request for Plasma.

By Maarten De Meyer.

Updated June 29, 2012, 11:13 a.m.

Descripti= on

This fixes the minimum size of the following applets: showda=
shboard, systemloadviewer, pastebin, weatherstation and timer.
Some sizes were to small, so there were visual glitches and some applets ha=
d no minimum value set.

I have no commit rights.

Testing <= /h1>

Run the applets with their new minimum size, and minimized.<=
/pre>

Diffs=

applets/pastebin/pastebin.cpp (208e6a3)
applets/showdashboard/showdashboard.h (695= 347f)
applets/showdashboard/showdashboard.cpp (1= c2f623)
applets/systemloadviewer/systemloadviewer.cpp (b852256)
applets/timer/timer.cpp (ba5ee66)
applets/weatherstation/weatherstation.h (6= d4ae24)
applets/weatherstation/weatherstation.cpp = (8ada9c2)

--===============7059925289882681173==-- --===============3089009890681864259== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3089009890681864259==--