'Re: Review Request: fix callback race in the session saving and shutdown code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: fix callback race in the session saving and shutdown code
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-25 17:55:08
Message-ID: 20120725175508.24578.14902 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105111/#review16382
-----------------------------------------------------------

This review has been submitted with commit 3af3f4c9c5bef5a3297ab50bcd445063b7441680 \
by Raphael Kubo da Costa to branch KDE/4.9.

- Commit Hook

On May 31, 2012, 8:48 a.m., Andriy Gapon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105111/
> -----------------------------------------------------------
> 
> (Updated May 31, 2012, 8:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch tries to a fix a race in the session saving and shutdown code of \
> ksmserver. The race may happen on wmPhase1WaitingCount variable when WM-type \
> clients are fast enough to complete their save requests while the loop in \
> KSMServer::shutdown is still iterating.  As a result wmPhase1WaitingCount may \
> become zero too early and that would kick off the next save/shutdown phase in a \
> client's callback.  In fact, it might even go multiple times from zero to non-zero \
> and back during the WM-specific loop. 
> 
> This addresses bug 206511.
> http://bugs.kde.org/show_bug.cgi?id=206511
> 
> 
> Diffs
> -----
> 
> ksmserver/shutdown.cpp a5a1ef9 
> 
> Diff: http://git.reviewboard.kde.org/r/105111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andriy Gapon
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105111/">http://git.reviewboard.kde.org/r/105111/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3af3f4c9c5bef5a3297ab50bcd445063b7441680 by Raphael Kubo da \
Costa to branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 31st, 2012, 8:48 a.m., Andriy Gapon wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andriy Gapon.</div>

<p style="color: grey;"><i>Updated May 31, 2012, 8:48 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch tries to a fix a race in the session saving and shutdown code \
of ksmserver. The race may happen on wmPhase1WaitingCount variable when WM-type \
clients are fast enough to complete their save requests while the loop in \
KSMServer::shutdown is still iterating.  As a result wmPhase1WaitingCount may become \
zero too early and that would kick off the next save/shutdown phase in a client&#39;s \
callback.  In fact, it might even go multiple times from zero to non-zero and back \
during the WM-specific loop.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=206511">206511</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/shutdown.cpp <span style="color: grey">(a5a1ef9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105111/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 