This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105111/

This review has been submitted with commit 3af3f4c9c5bef5a3297ab50bcd445063b7441680 by Raphael Kubo da Costa to branch KDE/4.9.

- Commit


On May 31st, 2012, 8:48 a.m., Andriy Gapon wrote:

Review request for Plasma.
By Andriy Gapon.

Updated May 31, 2012, 8:48 a.m.

Description

This patch tries to a fix a race in the session saving and shutdown code of ksmserver.
The race may happen on wmPhase1WaitingCount variable when WM-type clients are fast enough to complete their save requests while the loop in KSMServer::shutdown is still iterating.  As a result wmPhase1WaitingCount may become zero too early and that would kick off the next save/shutdown phase in a client's callback.  In fact, it might even go multiple times from zero to non-zero and back during the WM-specific loop.
Bugs: 206511

Diffs

  • ksmserver/shutdown.cpp (a5a1ef9)

View Diff