--===============4354833808595866930== Content-Type: multipart/alternative; boundary="===============4346751588903159145==" --===============4346751588903159145== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105111/#review16382 ----------------------------------------------------------- This review has been submitted with commit 3af3f4c9c5bef5a3297ab50bcd445063= b7441680 by Raphael Kubo da Costa to branch KDE/4.9. - Commit Hook On May 31, 2012, 8:48 a.m., Andriy Gapon wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105111/ > ----------------------------------------------------------- > = > (Updated May 31, 2012, 8:48 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This patch tries to a fix a race in the session saving and shutdown code = of ksmserver. > The race may happen on wmPhase1WaitingCount variable when WM-type clients= are fast enough to complete their save requests while the loop in KSMServe= r::shutdown is still iterating. As a result wmPhase1WaitingCount may becom= e zero too early and that would kick off the next save/shutdown phase in a = client's callback. In fact, it might even go multiple times from zero to n= on-zero and back during the WM-specific loop. > = > = > This addresses bug 206511. > http://bugs.kde.org/show_bug.cgi?id=3D206511 > = > = > Diffs > ----- > = > ksmserver/shutdown.cpp a5a1ef9 = > = > Diff: http://git.reviewboard.kde.org/r/105111/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Andriy Gapon > = > --===============4346751588903159145== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105111/

This revie=
w has been submitted with commit 3af3f4c9c5bef5a3297ab50bcd445063b7441680 b=
y Raphael Kubo da Costa to branch KDE/4.9.

- Commit

On May 31st, 2012, 8:48 a.m., Andriy Gapon wrote:

Review request for Plasma.

By Andriy Gapon.

Updated May 31, 2012, 8:48 a.m.

Descripti= on

This patch tries to a fix a race in the session saving and s=
hutdown code of ksmserver.
The race may happen on wmPhase1WaitingCount variable when WM-type clients a=
re fast enough to complete their save requests while the loop in KSMServer:=
:shutdown is still iterating.  As a result wmPhase1WaitingCount may become =
zero too early and that would kick off the next save/shutdown phase in a cl=
ient's callback.  In fact, it might even go multiple times from zero to=
 non-zero and back during the WM-specific loop.

Bugs: 206511

Diffs=

ksmserver/shutdown.cpp (a5a1ef9)

View Diff

--===============4346751588903159145==-- --===============4354833808595866930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4354833808595866930==--