'Re: Review Request: use window role to detect the dashboard'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: use window role to detect the dashboard
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2012-06-28 20:23:23
Message-ID: 20120628202323.10584.82254 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote:
> > Nice catch!
> > I do not have a printer that supports reporting ink levels, so I cannot test \
> > whether it causes unexpected behavior, but I don't think so. Daniel should look \
> > over this anyway. Thanks for the patch! :)

Sorry, Wrong Review! :D

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/#review15245
-----------------------------------------------------------

On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105382/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 7:42 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> see bug. i guess the window role is the natural and more distinct hint.
> 
> 
> This addresses bug 302523.
> http://bugs.kde.org/show_bug.cgi?id=302523
> 
> 
> Diffs
> -----
> 
> kwin/effects/dashboard/dashboard.cpp bb803a9 
> plasma/desktop/shell/dashboardview.cpp d6762b6 
> 
> Diff: http://git.reviewboard.kde.org/r/105382/diff/
> 
> 
> Testing
> -------
> 
> yes, dashboard still triggers the effect, renamed xterm no longer
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105382/">http://git.reviewboard.kde.org/r/105382/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 28th, 2012, 8:21 p.m., <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Nice catch! I do not have a printer that supports reporting ink levels, \
so I cannot test whether it causes unexpected behavior, but I don't think so. Daniel \
should look over this anyway. Thanks for the patch! :)</pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, Wrong Review! \
:D</pre> <br />

<p>- Kai Uwe</p>

<br />
<p>On June 28th, 2012, 7:42 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated June 28, 2012, 7:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see bug. i guess the window role is the natural and more distinct \
hint.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, dashboard still triggers the effect, renamed xterm no longer</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=302523">302523</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/dashboard/dashboard.cpp <span style="color: \
grey">(bb803a9)</span></li>

 <li>plasma/desktop/shell/dashboardview.cpp <span style="color: \
grey">(d6762b6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105382/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 