--===============8894325399613387734== Content-Type: multipart/alternative; boundary="===============5782896850629531095==" --===============5782896850629531095== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: > > Nice catch! > > I do not have a printer that supports reporting ink levels, so I cannot= test whether it causes unexpected behavior, but I don=E2=80=99t think so. > > Daniel should look over this anyway. > > Thanks for the patch! :) Sorry, Wrong Review! :D - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 ----------------------------------------------------------- On June 28, 2012, 7:42 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105382/ > ----------------------------------------------------------- > = > (Updated June 28, 2012, 7:42 p.m.) > = > = > Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gr=C3=A4=C3= =9Flin. > = > = > Description > ------- > = > see bug. i guess the window role is the natural and more distinct hint. > = > = > This addresses bug 302523. > http://bugs.kde.org/show_bug.cgi?id=3D302523 > = > = > Diffs > ----- > = > kwin/effects/dashboard/dashboard.cpp bb803a9 = > plasma/desktop/shell/dashboardview.cpp d6762b6 = > = > Diff: http://git.reviewboard.kde.org/r/105382/diff/ > = > = > Testing > ------- > = > yes, dashboard still triggers the effect, renamed xterm no longer > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============5782896850629531095== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105382/

On June 28th, 2012, 8:21 p.m., Kai Uwe Brou= lik wrote:

Nice catc=
h!
I do not have a printer that supports reporting ink levels, so I cannot tes=
t whether it causes unexpected behavior, but I don=E2=80=99t think so.
Daniel should look over this anyway.
Thanks for the patch! :)
Sorry, Wron=
g Review! :D

- Kai Uwe


On June 28th, 2012, 7:42 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gr=C3=A4= =C3=9Flin.
By Thomas L=C3=BCbking.

Updated June 28, 2012, 7:42 p.m.

Descripti= on 

see bug. i guess the window role is the natural and more dis=
tinct hint.

Testing <= /h1> 
yes, dashboard still triggers the effect, renamed xterm no l=
onger
Bugs: 302523

Diffs=

  • kwin/effects/dashboard/dashboard.cpp (bb80= 3a9)
  • plasma/desktop/shell/dashboardview.cpp (d6= 762b6)

View Diff
--===============5782896850629531095==-- --===============8894325399613387734== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8894325399613387734==--