This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/

On June 28th, 2012, 8:21 p.m., Kai Uwe Broulik wrote:

Nice catch!
I do not have a printer that supports reporting ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so.
Daniel should look over this anyway.
Thanks for the patch! :)

Sorry, Wrong Review! :D

- Kai Uwe

On June 28th, 2012, 7:42 p.m., Thomas Lübking wrote:

Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.

By Thomas Lübking.

Updated June 28, 2012, 7:42 p.m.

Description

see bug. i guess the window role is the natural and more distinct hint.

Testing

yes, dashboard still triggers the effect, renamed xterm no longer

Bugs: 302523

Diffs

kwin/effects/dashboard/dashboard.cpp (bb803a9)
plasma/desktop/shell/dashboardview.cpp (d6762b6)

View Diff