[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Bug Marble globe wallpaper, reversed spin direction
From: "Greg T" <yellowcake- () gmx ! net>
Date: 2012-05-31 13:54:52
Message-ID: 20120531135452.16212.70078 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 31, 2012, 1:08 p.m., Dennis Nienhüser wrote:
> > Polarity determines whether north is visible top or bottom, so I don't know why \
> > the original code was there.
> > I think you can even strip it down further to a simple
> > qreal const direction = polarity < 0 ? -1 : 1;
> >
> > i.e. ignore the projection -- in non-spherical case polarity is 1.
> >
> > Note that your patch also fixes bug 216156. You could use zoomIn()/zoomOut() \
> > though instead of the hard-coded +/- 40.
Thanks for clarification. I could not find zoomIn/Out in MarbleMap. Unfortunately \
this plasma wallpaper doesn't use MarbleWidget.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105118/#review14296
-----------------------------------------------------------
On May 31, 2012, 12:52 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105118/
> -----------------------------------------------------------
>
> (Updated May 31, 2012, 12:52 p.m.)
>
>
> Review request for Marble and Plasma.
>
>
> Description
> -------
>
> I had to delete a bunch of code to fix the issue. But what was the purpose of this \
> code? Am I missing some cornercase?
>
> This addresses bug 264755.
> http://bugs.kde.org/show_bug.cgi?id=264755
>
>
> Diffs
> -----
>
> wallpapers/marble/marble.cpp 988a8b6
>
> Diff: http://git.reviewboard.kde.org/r/105118/diff/
>
>
> Testing
> -------
>
> bug fixed.
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105118/">http://git.reviewboard.kde.org/r/105118/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 31st, 2012, 1:08 p.m., <b>Dennis \
Nienhüser</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Polarity determines whether north is visible top or bottom, so I \
don't know why the original code was there.
I think you can even strip it down further to a simple
qreal const direction = polarity < 0 ? -1 : 1;
i.e. ignore the projection -- in non-spherical case polarity is 1.
Note that your patch also fixes bug 216156. You could use zoomIn()/zoomOut() though \
instead of the hard-coded +/- 40.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for \
clarification. I could not find zoomIn/Out in MarbleMap. Unfortunately this plasma \
wallpaper doesn't use MarbleWidget.</pre> <br />
<p>- Greg</p>
<br />
<p>On May 31st, 2012, 12:52 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Marble and Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated May 31, 2012, 12:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I had to delete a bunch of code to fix the issue. But what was the \
purpose of this code? Am I missing some cornercase?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bug fixed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=264755">264755</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/marble/marble.cpp <span style="color: grey">(988a8b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105118/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic